Skip to content

Commit ec87bb4

Browse files
authored
update() function on longer name _t and _dt (#183)
`update()` function on longer need `_t` and `_dt`
2 parents f81498b + ffab348 commit ec87bb4

File tree

2 files changed

+27
-11
lines changed

2 files changed

+27
-11
lines changed

brainpy/dyn/runners.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -168,11 +168,11 @@ def func(_t, _dt):
168168
return func
169169

170170
def _run_one_step(self, _t):
171-
self._input_step(_t=_t, _dt=self.dt)
172-
self.target.update(_t=_t, _dt=self.dt)
171+
self._input_step(_t, self.dt)
172+
self.target.update(_t, self.dt)
173173
if self.progress_bar:
174174
id_tap(lambda *args: self._pbar.update(), ())
175-
return self._monitor_step(_t=_t, _dt=self.dt)
175+
return self._monitor_step(_t, self.dt)
176176

177177
def build_run_function(self):
178178
if self.jit:

brainpy/dyn/tests/test_dyn_runner.py

Lines changed: 24 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,36 @@
11
# -*- coding: utf-8 -*-
22

33

4+
import unittest
45
import brainpy as bp
56
import brainpy.math as bm
67

78

8-
class ExampleDS(bp.dyn.DynamicalSystem):
9-
def __init__(self):
10-
super(ExampleDS, self).__init__()
11-
self.i = bm.Variable(bm.zeros(1))
12-
self.o = bm.Variable(bm.zeros(2))
9+
class TestDSRunner(unittest.TestCase):
10+
def test1(self):
11+
class ExampleDS(bp.dyn.DynamicalSystem):
12+
def __init__(self):
13+
super(ExampleDS, self).__init__()
14+
self.i = bm.Variable(bm.zeros(1))
1315

14-
def update(self, _t, _dt):
15-
self.i += 1
16+
def update(self, _t, _dt):
17+
self.i += 1
1618

19+
ds = ExampleDS()
20+
runner = bp.dyn.DSRunner(ds, dt=1., monitors=['i'], progress_bar=False)
21+
runner.run(100.)
22+
23+
def test_t_and_dt(self):
24+
class ExampleDS(bp.dyn.DynamicalSystem):
25+
def __init__(self):
26+
super(ExampleDS, self).__init__()
27+
self.i = bm.Variable(bm.zeros(1))
28+
29+
def update(self, t, dt):
30+
self.i += 1 * dt
31+
32+
runner = bp.dyn.DSRunner(ExampleDS(), dt=1., monitors=['i'], progress_bar=False)
33+
runner.run(100.)
1734

1835
# class TestMonitor(TestCase):
1936
# def test_1d_array(self):
@@ -62,4 +79,3 @@ def update(self, _t, _dt):
6279
# assert np.ndim(try3.mon.a) == 2 and np.shape(try3.mon.a)[1] == 1
6380
# series = np.arange(2, 1002, 1. / 0.1).reshape((-1, 1))
6481
# assert np.allclose(series, try3.mon.a)
65-

0 commit comments

Comments
 (0)