Merge pull request #47 from braintree/dynamic-rtn-validation

add function to check routing numbers dynamically

Author: adrmachado-public

CHANGELOG.md

@@ -1,10 +1,14 @@
 # CHANGELOG
 
+## UNRELEASED
+
+- Changed routing number validity from checks against static list to dynamic checking against [standard ABA RTN formats](https://en.wikipedia.org/wiki/Routing_transit_number#MICR_routing_number_format)
+
 ## 1.0.1
 
 - Updates (sub-)dependencies
   - `braces` to 3.0.3
-  - `cross-spawn` to 7.0.6 
+  - `cross-spawn` to 7.0.6
   - `micromatch` to 4.0.8
 
 ## 1.0.0

README.md

@@ -57,7 +57,7 @@ Will return something like this:
 }
 ```
 
-Valid routing numbers come from a hard-coded list of possible numbers, which you can find in `src/routing-number-list.js`.
+Valid routing numbers are checked against [MICR number format](https://en.wikipedia.org/wiki/Routing_transit_number#MICR_routing_number_format). We test this formula against a number of known routing numbers, which can be found at `src/routing-to-bank-name.json`.
 
 ### `valid.accountNumber(value: string): object`
 

package-lock.json

@@ -15,8 +15,7 @@
     "build": "tsc --declaration",
     "lint": "eslint --ext js,ts .",
     "posttest": "npm run lint",
-    "test": "jest",
-    "build-routing-list": "ts-node scripts/build-routing-list"
+    "test": "jest"
   },
   "author": "Braintree <code@getbraintree.com> (https://www.braintreepayments.com/)",
   "license": "MIT",

package.json

@@ -50,6 +50,14 @@ describe("routingNumber", () => {
     });
   });
 
+  it("can validate a potentially valid routing number dynamically", () => {
+    // 645442104 is not an assigned routing number, but has a valid form
+    expect(routingNumber("645442104")).toEqual({
+      isValid: true,
+      isPotentiallyValid: true,
+    });
+  });
+
   it("is invalid for numbers that are too long", () => {
     ["3224844012", "32248440100", "0322484401"].forEach((value) => {
       expect(routingNumber(value)).toEqual({
@@ -59,7 +67,7 @@ describe("routingNumber", () => {
     });
   });
 
-  it("is invalid for values not in the list", () => {
+  it("is returns false for invalid routing numbers", () => {
     [
       "999999999",
       "074986820 ",