US model Aliases

[alvinchen1]

Howdy! I was looking over the changes in #738 and that seems to have opened up a lot of supported models for me. Awesome work! A few questions:

1. I am attempting to understand the mapping in aliases.py, and I think I comprehend it, but my read of it is that there are models like LCA005 which map to LCA001, right (ref: line 92)? If that's the case, then would it not also make sense to update supported_models.md to include LCA005, for example? I'd like to contribute. I tried to create a forked repository and branch, edited the file with all the US aliases but couldn't commit it. I think I need a basic GitHub 101 lesson (obviously not for this forum to resolve my education issues).

2. I have a model LCF001 which I believe can be aliased to the LCF002 (Hue Calla Outdoor Pedestal). What information do you need to approve an alias like this? I'll be happy to dig up whatever I can to help contribute and expand to include this model.

Awesome work as always, sorry I'm not more contributing. I did try to submit a branch/pull request for 1), but I must be doing something stupid.

[bramstroker]

I don't see any forked repository on your github profile. https://github.com/alvinchen1?tab=repositories.
When you clicked fork on my repository your should also have a powercalc repository on your profile. After you make a commit on your fork you should be able to create a new Pull Request by clicking the "new pull request" button on the pull request tab.

Currently the supported_models.md reads all the model.json files from the data directory. This needs to be altered to also read aliases, but than we don't have name information. I will figure something out for this in the future as we are adding more aliases lately and it will make sense that users can also find the is the supported list.

I cannot find much information about LCF001 and LCF002 on google, so I also don't know how to know if they are similar yet.

[alvinchen1]

Yup! I created a forked repository, worked on changing supported models, created a branch, and tried to commit, but couldn't and couldn't figure out why. So I deleted the repository and am going to try again sometime. I'm probably doing something really stupid, since I'm so new to this.

As for the LCF001 vs LCF002, I see published info on LCF002 (like https://zigbee.blakadder.com/Philips_LCF002.html) but you're right, not much on LCF001, which I would think would be similar, but not sure how we can confirm.

[bramstroker]

btw aliases have been added to supported models https://github.com/bramstroker/homeassistant-powercalc/blob/master/docs/supported_models.md.
I will also make changes to mention the US models as a seperate row, but this will be a second iteration.

[alvinchen1]

Howdy, been a bit of time, but looks like there is now some information on the LCF001

https://zigbee.blakadder.com/Philips_LCF001.html
https://zigbee.blakadder.com/Philips_LCF002.html

On this site, it shows that the Product Code

Product Codes for LCF001:
8718696167991
915005630301

Product Codes for LCF002:
8718696167991
046677802097
046677802080

Since the product code 8718696167991 matches between them is that sufficient to alias LCF001 to LCF002?