Skip to content

Commit 7a9c9e5

Browse files
committed
properly comment config validation code that relies on directory-level config. This should be moved to a request-level validation function.
1 parent c3bbf32 commit 7a9c9e5

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/mod_auth_openidc.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1417,7 +1417,7 @@ static int oidc_check_config_error(server_rec *s, const char *config_str) {
14171417
static int oidc_check_config_openid_openidc(server_rec *s, oidc_cfg_t *c) {
14181418

14191419
apr_uri_t r_uri;
1420-
apr_byte_t redirect_uri_is_relative;
1420+
//apr_byte_t redirect_uri_is_relative;
14211421

14221422
if ((oidc_cfg_metadata_dir_get(c) == NULL) &&
14231423
(oidc_cfg_provider_issuer_get(oidc_cfg_provider_get(c)) == NULL) &&
@@ -1472,10 +1472,10 @@ static int oidc_check_config_openid_openidc(server_rec *s, oidc_cfg_t *c) {
14721472
// }
14731473

14741474
if (oidc_cfg_cookie_domain_get(c) != NULL) {
1475-
if (redirect_uri_is_relative) {
1475+
/*if (redirect_uri_is_relative) {
14761476
oidc_swarn(s, "if the configured " OIDCRedirectURI " is relative, " OIDCCookieDomain
14771477
" SHOULD be empty");
1478-
} else if (!oidc_util_cookie_domain_valid(r_uri.hostname, oidc_cfg_cookie_domain_get(c))) {
1478+
} else*/ if (!oidc_util_cookie_domain_valid(r_uri.hostname, oidc_cfg_cookie_domain_get(c))) {
14791479
oidc_serror(s,
14801480
"the domain (%s) configured in " OIDCCookieDomain
14811481
" does not match the URL hostname (%s) of the configured " OIDCRedirectURI

0 commit comments

Comments
 (0)