Merge branch 'WoWAnalyzer:midnight' into unholy-midnight-cooldown-tracking

Author: brandrewsss

src/CHANGELOG.tsx

@@ -30,6 +30,7 @@ import SpellLink from 'interface/SpellLink';
 
 // prettier-ignore
 export default [
+  change(date(2026, 2, 10), 'Prevent duplicate GCDs triggering for normalized channels', Vollmer),
   change(date(2026, 2, 1), 'Fix playwright tests for specs with partial support', Vollmer),
   change(date(2026, 1, 29), 'RU: improve localization on key pages (news/about/specs/premium/help-wanted) and make Panel headings fully translatable', SaltyRain),
   change(date(2026, 1, 27), 'Add support for Midnight gems and enchants.', Arlie),

src/analysis/classic/priest/shadow/CombatLogParser.ts

@@ -1,7 +1,6 @@
 // Base files
 import BaseCombatLogParser from 'parser/classic/CombatLogParser';
 // Core
-import GlobalCooldown from './modules/core/GlobalCooldown';
 // Shared
 import { Haste } from '../shared';
 import ManaTracker from 'parser/core/healingEfficiency/ManaTracker';
@@ -19,7 +18,6 @@ import Shadowfiend from './modules/spells/Shadowfiend';
 class CombatLogParser extends BaseCombatLogParser {
   static specModules = {
     // Core
-    globalCooldown: GlobalCooldown,
     // Shared
     haste: Haste,
     manaTracker: ManaTracker,

src/analysis/classic/priest/shadow/modules/core/GlobalCooldown.tsx

@@ -1,9 +1,12 @@
 import { change, date } from 'common/changelog';
 import { Topple, Texleretour } from 'CONTRIBUTORS';
 import SHARED_CHANGELOG from 'analysis/retail/demonhunter/shared/CHANGELOG';
+import SpellLink from 'interface/SpellLink';
+import { TALENTS_DEMON_HUNTER } from 'common/TALENTS';
 
 // prettier-ignore
 export default [
+  change(date(2026, 2, 7), <>{<SpellLink spell={TALENTS_DEMON_HUNTER.VOID_METAMORPHOSIS_TALENT} />} cast analysis</>, Texleretour),
   change(date(2026, 2, 3), 'Core analysis', Texleretour),
   change(date(2026, 1, 30), 'Add more complete foundation', Texleretour),
   change(date(2025, 10, 24), 'Add basic support for the spec.', Topple),

src/analysis/retail/demonhunter/devourer/CHANGELOG.tsx

@@ -11,7 +11,7 @@ const CONFIG: Config = {
   branch: GameBranch.Retail,
   // The WoW client patch this spec was last updated.
   patchCompatibility: '12.0.0',
-  supportLevel: SupportLevel.Foundation,
+  supportLevel: SupportLevel.MaintainedPartial,
   // Explain the status of this spec's analysis here. Try to mention how complete it is, and perhaps show links to places users can learn more.
   // If this spec's analysis does not show a complete picture please mention this in the `<Warning>` component.
   description: (

src/analysis/retail/demonhunter/devourer/CONFIG.tsx

@@ -2,7 +2,6 @@ import CoreCombatLogParser from 'parser/core/CombatLogParser';
 import Channeling from 'parser/shared/normalizers/Channeling';
 import ArcaneTorrent from 'parser/shared/modules/racials/bloodelf/ArcaneTorrent';
 import { Buffs } from 'analysis/retail/demonhunter/devourer/modules/Buffs';
-import { GlobalCooldown } from 'analysis/retail/demonhunter/devourer/modules/core/GlobalCooldown';
 import { AlwaysBeCasting } from 'analysis/retail/demonhunter/devourer/modules/features/AlwaysBeCasting';
 import CooldownThroughputTracker from 'analysis/retail/demonhunter/devourer/modules/features/CooldownThroughputTracker';
 import { FuryTracker } from 'analysis/retail/demonhunter/devourer/modules/resourcetracker/FuryTracker';
@@ -20,15 +19,15 @@ import VoidMetamorphosis from './modules/talents/VoidMetamorphosis';
 import Voidstep from './modules/buffs/Voidstep';
 import Reap from './modules/spells/Reap';
 import Cull from './modules/spells/Cull';
+import VoidRay from './modules/talents/VoidRay';
+import VoidRayEventLinkNormalizer from './normalizers/VoidRayEventLinkNormalizer';
 
 class CombatLogParser extends CoreCombatLogParser {
   static specModules = {
     // Core Statistics
     channeling: Channeling,
     buffs: Buffs,
 
-    globalCooldown: GlobalCooldown,
-
     // Features
     alwaysBeCasting: AlwaysBeCasting,
     abilities: Abilities,
@@ -44,6 +43,7 @@ class CombatLogParser extends CoreCombatLogParser {
     momentOfCraving: MomentOfCraving,
     massAcceleration: MassAcceleration,
     voidMetamorphosis: VoidMetamorphosis,
+    voidRay: VoidRay,
 
     // Buffs
     voidstep: Voidstep,
@@ -58,6 +58,7 @@ class CombatLogParser extends CoreCombatLogParser {
 
     // Normalizers
     voidMetamorphosisNormalizer: VoidMetamorphosisNormalizer,
+    voidRayEventLinkNormalizer: VoidRayEventLinkNormalizer,
 
     // There's no throughput benefit from casting Arcane Torrent on cooldown
     arcaneTorrent: [ArcaneTorrent, { castEfficiency: null }] as const,

src/analysis/retail/demonhunter/devourer/CombatLogParser.tsx

@@ -12,3 +12,7 @@ export const MOMENT_OF_CRAVING_ADDITIONAL_SOUL_ABSORB_CAPACITY = 6;
 
 export const VOID_METAMORPHOSIS_BASE_SOULS_COST = 50;
 export const VOID_METAMORPHOSIS_SOUL_GLUTTON_SOULS_COST = 35;
+
+export const VOID_RAY_MAX_TICKS = 21;
+// Void Ray receives a cooldown during Void Metamorphosis only
+export const VOID_RAY_COOLDOWN_VOID_METAMORPHOSIS = (haste: number) => 16 / (1 + haste);

src/analysis/retail/demonhunter/devourer/constants.ts

@@ -5,6 +5,7 @@ import ActiveTimeGraph from 'parser/ui/ActiveTimeGraph';
 import CombatLogParser from '../CombatLogParser';
 import SpellLink from 'interface/SpellLink';
 import SPELLS from 'common/SPELLS';
+import { TALENTS_DEMON_HUNTER } from 'common/TALENTS';
 
 function CoreSection({ modules, info }: GuideProps<typeof CombatLogParser>) {
   return (
@@ -15,9 +16,10 @@ function CoreSection({ modules, info }: GuideProps<typeof CombatLogParser>) {
             Continuously casting throughout an encounter is the single most important thing for
             achieving good DPS.
           </b>
-          <br />
-          Some fights have unavoidable downtime due to phase transitions and the like, so in these
-          cases 0% downtime will not be possible - do the best you can.
+          <div>
+            Some fights have unavoidable downtime due to phase transitions and the like, so in these
+            cases 0% downtime will not be possible - do the best you can.
+          </div>
         </p>
         <p>
           Remember that you always have access to either <SpellLink spell={SPELLS.CONSUME} /> or{' '}
@@ -37,6 +39,8 @@ function CoreSection({ modules, info }: GuideProps<typeof CombatLogParser>) {
       </SubSection>
 
       {modules.reap.guideSubsection()}
+      {info.combatant.hasTalent(TALENTS_DEMON_HUNTER.VOID_RAY_TALENT) &&
+        modules.voidRay.guideSubsection()}
     </Section>
   );
 }

src/analysis/retail/demonhunter/devourer/guide/CoreSection.tsx

@@ -1,8 +1,13 @@
 import { GuideProps, Section } from 'interface/guide';
 import CombatLogParser from '../CombatLogParser';
+import { TALENTS_DEMON_HUNTER } from 'common/TALENTS';
 
-function ProcsAndBuffsSection({ modules }: GuideProps<typeof CombatLogParser>) {
-  return <Section title="Procs">{modules.voidstep.guideSubsection()}</Section>;
+function ProcsAndBuffsSection({ modules, info }: GuideProps<typeof CombatLogParser>) {
+  return info.combatant.hasTalent(TALENTS_DEMON_HUNTER.HUNGERING_SLASH_TALENT) ? (
+    <Section title="Procs">{modules.voidstep.guideSubsection()}</Section>
+  ) : (
+    <></>
+  );
 }
 
 export default ProcsAndBuffsSection;

src/analysis/retail/demonhunter/devourer/guide/ProcsAndBuffsSection.tsx

@@ -18,7 +18,7 @@ class Abilities extends SharedAbilities {
         },
       },
       {
-        spell: [SPELLS.HUNGERING_SLASH_CAST.id, SPELLS.REAPERS_TOLL.id],
+        spell: [SPELLS.HUNGERING_SLASH_CAST.id, SPELLS.REAPERS_TOLL_CAST.id],
         enabled: combatant.hasTalent(TALENTS_DEMON_HUNTER.HUNGERING_SLASH_TALENT),
         category: SPELL_CATEGORY.ROTATIONAL,
         gcd: {