Merge branch 'WoWAnalyzer:midnight' into unholy-midnight-proc-and-buff-tracking

Author: brandrewsss

src/analysis/retail/shaman/enhancement/CHANGELOG.tsx

@@ -1,9 +1,10 @@
 import { change, date } from 'common/changelog';
 import { TALENTS_SHAMAN } from 'common/TALENTS';
-import { Seriousnes } from 'CONTRIBUTORS';
+import { Seriousnes, Texleretour } from 'CONTRIBUTORS';
 import SpellLink from 'interface/SpellLink';
 
 // prettier-ignore
 export default [
+    change(date(2026, 2, 12), <>Fix typos and talent check issues.</>, Texleretour),
     change(date(2025, 12, 17), <>Updated for Midnight</>, Seriousnes)
 ];

src/analysis/retail/shaman/enhancement/modules/Abilities.tsx

@@ -69,7 +69,7 @@ class Abilities extends ClassAbilities {
         spell: SPELLS.PRIMORDIAL_STORM_CAST.id,
         category: SPELL_CATEGORY.COOLDOWNS,
         gcd: {
-          base: 150,
+          base: 1500,
         },
         enabled: combatant.hasTalent(TALENTS.PRIMORDIAL_STORM_TALENT),
       },

src/analysis/retail/shaman/enhancement/modules/talents/HotHand.tsx

@@ -390,7 +390,7 @@ class HotHand extends MajorCooldown<HotHandProc> {
               <SpellLink spell={TALENTS.SUNDERING_TALENT} /> cast by {ll} will also trigger an{' '}
               <SpellLink spell={TALENTS.EARTHSURGE_TALENT} /> half way along{' '}
               <SpellLink spell={TALENTS.SUNDERING_TALENT} />
-              's path
+              's path.
             </>
           ) : null}
         </p>

src/analysis/retail/shaman/enhancement/modules/talents/PrimordialStorm.tsx

@@ -21,7 +21,6 @@ interface PrimordialStormCast extends CooldownTrigger<CastEvent> {
     maelstromUsed: number;
     shouldHaveHadDoomwinds: boolean;
     hadDoomwinds: boolean;
-    legacyOfTheFrostWitch: boolean;
     surgingElementsActive: boolean;
   };
 }
@@ -61,10 +60,6 @@ class PrimordialStorm extends MajorCooldown<PrimordialStormCast> {
     const details: PrimordialStormCast['details'] = {
       shouldHaveHadDoomwinds: this.doomWindsAlternater,
       hadDoomwinds,
-      legacyOfTheFrostWitch: this.selectedCombatant.hasBuff(
-        SPELLS.LIGHTNING_STRIKES_BUFF,
-        event.timestamp,
-      ),
       maelstromUsed: this.resourceTracker.lastSpenderInfo?.amount ?? 0,
       surgingElementsActive: this.selectedCombatant.hasBuff(
         SPELLS.SURGING_ELEMENTS_BUFF,
@@ -82,14 +77,6 @@ class PrimordialStorm extends MajorCooldown<PrimordialStormCast> {
       );
     }
 
-    if (!details.legacyOfTheFrostWitch) {
-      lis.push(
-        <>
-          <SpellLink spell={SPELLS.LIGHTNING_STRIKES_BUFF} /> was missing.
-        </>,
-      );
-    }
-
     if (details.maelstromUsed < 10) {
       lis.push(
         <>
@@ -145,9 +132,7 @@ class PrimordialStorm extends MajorCooldown<PrimordialStormCast> {
         <p>
           Each hit from {pstorm} is considered a Main-Hand attack, and can trigger{' '}
           <SpellLink spell={TALENTS.WINDFURY_WEAPON_TALENT} /> separately and are AoE. Each hit
-          deals combination physical and spell damage, and all hits are amplified by{' '}
-          <SpellLink spell={SPELLS.LIGHTNING_STRIKES_BUFF} />, and{' '}
-          <SpellLink spell={SPELLS.PRIMORDIAL_FROST} /> is buffed twice.
+          deals combination physical and spell damage.
         </p>
         <p>
           {pstorm} is currently the <strong>strongest</strong> {msw} spender, and you should always
@@ -164,47 +149,13 @@ class PrimordialStorm extends MajorCooldown<PrimordialStormCast> {
     const details = cast.details;
 
     const maelstromUsed = details.maelstromUsed ?? 0;
-    const lotfwActive = details.legacyOfTheFrostWitch ?? false;
     const hadDoomwinds = details.hadDoomwinds ?? false;
     const shouldHaveHadDoomwinds = details.shouldHaveHadDoomwinds ?? false;
     const surgingElementsActive = details.surgingElementsActive ?? false;
 
     const issues: ReactNode[] = [];
     const checklistItems: ChecklistUsageInfo[] = [];
 
-    /**
-     * Legacy of the Frost Witch (buff)
-     */
-    checklistItems.push({
-      check: 'legacy-of-the-frost-witch',
-      timestamp: cast.event.timestamp,
-      performance: lotfwActive ? QualitativePerformance.Perfect : QualitativePerformance.Fail,
-      summary: (
-        <>
-          <SpellLink spell={SPELLS.LIGHTNING_STRIKES_BUFF} /> {lotfwActive ? '' : 'not'}
-          active.
-        </>
-      ),
-      details: (
-        <div>
-          <SpellLink spell={SPELLS.LIGHTNING_STRIKES_BUFF} /> {lotfwActive ? '' : 'not'}
-          active.
-          {!lotfwActive && (
-            <> This is a significant damage increase, aim to have it active for every cast.</>
-          )}
-        </div>
-      ),
-    });
-    if (!lotfwActive) {
-      issues.push(
-        <>
-          <li key="lotfw">
-            <SpellLink spell={SPELLS.LIGHTNING_STRIKES_BUFF} /> should be active for every cast.
-          </li>
-        </>,
-      );
-    }
-
     /**
      * Maelstrom Used
      */
@@ -226,7 +177,7 @@ class PrimordialStorm extends MajorCooldown<PrimordialStormCast> {
       ),
       details: (
         <div>
-          <strong>{maelstromUsed}</strong> <SpellLink spell={TALENTS.MAELSTROM_WEAPON_TALENT} />
+          <strong>{maelstromUsed}</strong> <SpellLink spell={TALENTS.MAELSTROM_WEAPON_TALENT} />{' '}
           used.
         </div>
       ),
@@ -235,7 +186,7 @@ class PrimordialStorm extends MajorCooldown<PrimordialStormCast> {
       issues.push(
         <>
           <li key="maelstrom-weapon">
-            Aim to use <strong>10</strong> <SpellLink spell={TALENTS.MAELSTROM_WEAPON_TALENT} />
+            Aim to use <strong>10</strong> <SpellLink spell={TALENTS.MAELSTROM_WEAPON_TALENT} />{' '}
             each time you cast <SpellLink spell={TALENTS.PRIMORDIAL_STORM_TALENT} />.
           </li>
         </>,