Skip to content

Add semver-checks.yml #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atuchin-m merged 2 commits into from
Jan 20, 2026
Merged

Add semver-checks.yml #569

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d64dba6
Add sermver-checks.yml
atuchin-m Nov 17, 2025
9ba405c
use cargo-semver-checks-action
atuchin-m Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/semver-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: Semver Checks

on:
pull_request:
branches:
- master
workflow_dispatch:

permissions:
contents: read

jobs:
semver-checks:
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

- name: Check semver
uses: obi1kenobi/cargo-semver-checks-action@5b298c9520f7096a4683c0bd981a7ac5a7e249ae # v2.8
Copy link

@github-actions github-actions bot Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reported by reviewdog 🐶
[opengrep] An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA or is missing the semver reference comment

You can use pinact - https://github.com/suzuki-shunsuke/pinact - to pin them

👍

uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8 # v3.3.1

👎

uses: actions/cache@v3
uses: actions/[email protected]

GHA Policies


Source: https://github.com/brave/security-action/blob/main/assets/opengrep_rules/services/brave-third-party-action-not-pinned-to-commit-sha.yaml


Cc @thypon @kdenhartog

Copy link
Collaborator Author

@atuchin-m atuchin-m Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's pinned by fullhash. False positive?

Copy link
Collaborator Author

@atuchin-m atuchin-m Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kdenhartog @thypon
Could you take a look? Does using this action looks good in terms of security?

Copy link
Member

@kdenhartog kdenhartog Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked this PR with pinact and not seeing any issues - LGTM