display an error, if a backup archive file wasn't created

Author: Alex Schulte

Classes/Command/BackupCommandController.php

@@ -24,9 +24,14 @@ public function createCommand(): void
             $this->quit();
         }
 
-        $this->output('Creating backup...');
-        $this->backupService->createBackup();
-        $this->outputLine('<success>success</success>');
+        $this->outputLine('Creating backup...');
+
+        if (!$this->backupService->createBackup()) {
+            $this->outputLine('<error>couldn\'t create backup</error>');
+            $this->quit();
+        }
+
+        $this->outputLine('<success>backup created</success>');
     }
 
     /**

Classes/Service/BackupService.php

@@ -148,13 +148,23 @@ public function createBackup()
         // create archive
         $compressor = $this->getCompressor();
         $archivePath = $compressor->compress($backupPath, $this->config['tempPath']);
+
+        if (!is_file($archivePath)) {
+            $this->logger->error('couldn\`t create backup archive file: ' . $archivePath);
+
+            return false;
+        }
+
         // upload to file system and delete local one
         $this->filesystem->writeStream(basename($archivePath), fopen($archivePath, 'r'));
         unlink($archivePath);
         Files::removeDirectoryRecursively($backupPath);
+
         // update index
         $this->indexService->addBackup($backupName, new \DateTime(), $meta);
         $this->logger->info('added backup '.$backupName);
+
+        return true;
     }
 
     /**