Skip to content

Attribute not removed in the DOM ( probably when setting the control back to default value )Β #85

@herrKlein

Description

@herrKlein

Hi,

again, thanks for this helper library. It saves so much time documenting all our components.

I have a reproducible 'bug' when setting a control back to its original state.

I added a shuffle property to the element in your stackblitz example

https://stackblitz.com/edit/github-zzm7be2d?file=README.md,src%2Fmy-element.ts

  @property({ type: String, reflect: true })
  shuffle: 'true' | 'false' = 'false';

There now is a control in storybook, the select.
When I set shuffle to true, the shuffle attribute shuffle="true" is shown inside the code block, and in the dom.

But when setting it back to false in the controls, in the code block the attribute disappears from the element. ( this appears to be correct, it is the default value ) .. but the attribute is not removed in the real dom element, shown in chrome devtools. it still is shuffle="true" in the DOM.

it should be removed in the DOM also.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions