Fix

Author: mnapoli

php-85/Dockerfile

@@ -176,10 +176,6 @@ RUN set -xe; \
     cp php.ini-production ${INSTALL_DIR}/etc/php/php.ini
 
 
-# From PHP 8.5 opcache is enabled by default, we need to remove the `zend_extension=opcache.so` line
-RUN sed -i '/^zend_extension=opcache.so/d' ${INSTALL_DIR}/etc/php/php.ini
-
-
 # Install extensions
 # We can install extensions manually or using `pecl`
 RUN pecl install APCu
@@ -229,7 +225,7 @@ FROM public.ecr.aws/lambda/provided:al2023-${IMAGE_VERSION_SUFFIX} as function
 # We selected the files in /bref-layer, now we copy them to /opt (the real directory for the Lambda layer)
 COPY --link --from=build-environment /bref-layer /opt
 
-COPY --link src/php.ini /opt/bref/etc/php/conf.d/bref.ini
+COPY --link src/php-85.ini /opt/bref/etc/php/conf.d/bref.ini
 COPY --link src/php-fpm.conf /opt/bref/etc/php-fpm.conf
 
 COPY --link src/bootstrap.sh /opt/bootstrap

src/php-85.ini

@@ -0,0 +1,53 @@
+; On the CLI we want errors to be sent to stdout -> those will end up in CloudWatch
+; In FPM workers we don't want that, but that is overridden by Bref when it starts PHP-FPM
+display_errors=1
+
+; Since PHP 7.4 the default value is E_ALL
+; We override it to set the recommended configuration value for production.
+; See https://github.com/php/php-src/blob/d91abf76e01a3c39424e8192ad049f473f900936/php.ini-production#L463
+error_reporting = E_ALL & ~E_DEPRECATED & ~E_STRICT
+
+memory_limit=10240M
+
+opcache.enable=1
+opcache.enable_cli=1
+
+; Store the opcodes into a file cache (on top of storing in memory)
+; With FPM, this is only useful if FPM restarts or if the shared memory cache is full.
+; With the function runtime, this is useful when the function restarts the PHP
+; process on every invocation.
+; TODO store in a subdirectory (but the problem is that the subdirectory doesn't exist when PHP starts...)
+opcache.file_cache="/tmp"
+; Disable the memory cache since it's useless
+; In my tests it allows to gain 30% of response time in a classic API controller
+opcache.file_cache_only=1
+; Skip this check to save a bit
+opcache.validate_permission=0
+
+; The code is readonly on lambdas so it never changes
+; This setting is now disabled: code could be written to /tmp which is read/write
+; (e.g. a compiled container) Such a performance optimization can be done by users.
+;opcache.validate_timestamps=0
+
+; Set sane values, modern PHP applications have higher needs than opcache's defaults
+; See https://tideways.com/profiler/blog/fine-tune-your-opcache-configuration-to-avoid-caching-suprises
+opcache.memory_consumption=128
+opcache.max_accelerated_files=10000
+
+; This directive determines which super global arrays are registered when PHP
+; starts up. G,P,C,E & S are abbreviations for the following respective super
+; globals: GET, POST, COOKIE, ENV and SERVER.
+; We explicitly populate all variables else ENV is not populated by default.
+; See https://github.com/brefphp/bref/pull/291
+variables_order="EGPCS"
+
+; The lambda environment is not compatible with fastcgi_finish_request
+; See https://github.com/brefphp/bref/issues/214
+disable_functions=fastcgi_finish_request
+
+; The total upload size limit is 6Mb, we override the defaults to match this limit
+; API Gateway has a 10Mb limit, but Lambda's is 6Mb
+post_max_size=6M
+upload_max_filesize=6M
+
+extension_dir=/opt/bref/extensions