Skip to content

Commit aac4450

Browse files
authored
Merge pull request #91 from GrahamCampbell/php-83
2 parents 36f3299 + 0b9c034 commit aac4450

File tree

5 files changed

+509
-12
lines changed

5 files changed

+509
-12
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
script: |
2626
const matrix = {
2727
cpu: ['x86', 'arm'],
28-
php_version: ['80', '81', '82'],
28+
php_version: ['80', '81', '82', '83'],
2929
}
3030
3131
// If this is a third-party pull request, skip ARM builds

Makefile

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,13 @@ default: docker-images layers
3535

3636

3737
# Build Docker images *locally*
38-
docker-images: docker-images-php-80 docker-images-php-81 docker-images-php-82
38+
docker-images: docker-images-php-80 docker-images-php-81 docker-images-php-82 docker-images-php-83
3939
docker-images-php-%:
4040
PHP_VERSION=$* ${BAKE_COMMAND} --load
4141

4242

4343
# Build Lambda layers (zip files) *locally*
44-
layers: layer-php-80 layer-php-81 layer-php-82 layer-php-80-fpm layer-php-81-fpm layer-php-82-fpm
44+
layers: layer-php-80 layer-php-81 layer-php-82 layer-php-83 layer-php-80-fpm layer-php-81-fpm layer-php-82-fpm layer-php-83-fpm
4545
# Build the console layer only once (x86 and single PHP version)
4646
@if [ ${CPU} = "x86" ]; then \
4747
$(MAKE) layer-console; \
@@ -57,7 +57,7 @@ layer-%:
5757
# Upload the layers to AWS Lambda
5858
# Uses the current AWS_PROFILE. Most users will not want to use this option
5959
# as this will publish all layers to all regions + publish all Docker images.
60-
upload-layers: upload-layers-php-80 upload-layers-php-81 upload-layers-php-82
60+
upload-layers: upload-layers-php-80 upload-layers-php-81 upload-layers-php-82 upload-layers-php-83
6161
# Upload the console layer only once (x86 and single PHP version)
6262
@if [ ${CPU} = "x86" ]; then \
6363
LAYER_NAME=console $(MAKE) -C ./utils/lambda-publish publish-parallel; \
@@ -70,7 +70,7 @@ upload-layers-php-%:
7070

7171

7272
# Publish Docker images to Docker Hub.
73-
upload-to-docker-hub: upload-to-docker-hub-php-80 upload-to-docker-hub-php-81 upload-to-docker-hub-php-82
73+
upload-to-docker-hub: upload-to-docker-hub-php-80 upload-to-docker-hub-php-81 upload-to-docker-hub-php-82 upload-to-docker-hub-php-83
7474
upload-to-docker-hub-php-%:
7575
for image in \
7676
"bref/${CPU_PREFIX}php-$*" "bref/${CPU_PREFIX}php-$*-fpm" "bref/${CPU_PREFIX}php-$*-console" \
@@ -81,12 +81,12 @@ upload-to-docker-hub-php-%:
8181
done
8282

8383

84-
test: test-80 test-81 test-82
84+
test: test-80 test-81 test-82 test-83
8585
test-%:
8686
cd tests && $(MAKE) test-$*
8787

8888

89-
clean: clean-80 clean-81 clean-82
89+
clean: clean-80 clean-81 clean-82 clean-83
9090
# Clear the build cache, else all images will be rebuilt using cached layers
9191
docker builder prune
9292
# Remove zip files

layers/fpm-dev/Dockerfile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,14 @@ ARG PHP_VERSION
1010
RUN mkdir -p /opt/bref/extensions
1111

1212
# Install xdebug
13-
RUN pecl install xdebug
14-
RUN cp $(php -r "echo ini_get('extension_dir');")/xdebug.so /opt/bref/extensions
13+
RUN if [ $PHP_VERSION != "83" ]; then pecl install xdebug; fi
14+
RUN if [ $PHP_VERSION != "83" ]; then cp $(php -r "echo ini_get('extension_dir');")/xdebug.so /opt/bref/extensions; fi
1515

1616
# Install Blackfire
1717
# https://blackfire.io/docs/up-and-running/installation?action=install&mode=full&version=latest&mode=full&location=server&os=manual&language=php#install-the-php-probe
1818
ARG BLACKFIRE_VERSION=1.87.2
19-
RUN if [[ $CPU_PREFIX == "" ]]; then curl -A "Docker" -o /opt/bref/extensions/blackfire.so -L -s "https://packages.blackfire.io/binaries/blackfire-php/$BLACKFIRE_VERSION/blackfire-php-linux_amd64-php-"$PHP_VERSION".so"; fi
20-
RUN if [[ $CPU_PREFIX == "arm-" ]]; then curl -A "Docker" -o /opt/bref/extensions/blackfire.so -L -s "https://packages.blackfire.io/binaries/blackfire-php/$BLACKFIRE_VERSION/blackfire-php-linux_arm64-php-"$PHP_VERSION".so"; fi
19+
RUN if [ $PHP_VERSION != "83" ] && [ $CPU_PREFIX == "" ]; then curl -A "Docker" -o /opt/bref/extensions/blackfire.so -L -s "https://packages.blackfire.io/binaries/blackfire-php/$BLACKFIRE_VERSION/blackfire-php-linux_amd64-php-"$PHP_VERSION".so"; fi
20+
RUN if [ $PHP_VERSION != "83" ] && [ $CPU_PREFIX == "arm-" ]; then curl -A "Docker" -o /opt/bref/extensions/blackfire.so -L -s "https://packages.blackfire.io/binaries/blackfire-php/$BLACKFIRE_VERSION/blackfire-php-linux_arm64-php-"$PHP_VERSION".so"; fi
2121

2222

2323
FROM bref/${CPU_PREFIX}php-${PHP_VERSION}-fpm

0 commit comments

Comments
 (0)