CLI design improvement

Author: mnapoli

src/Cli/BrefSpinner.php

@@ -39,7 +39,8 @@ class BrefSpinner
     ];
     private int $startTime;
     private string $message;
-    private int $currentFrame = 0;
+    private ?string $extraMessage = null;
+    private int $currentFrame = 7;
     private bool $started = true;
     private string $timerId;
     private ?Cursor $cursor;
@@ -81,7 +82,7 @@ public function advance(): void
     /**
      * Finish the indicator with message.
      */
-    public function finish(string $message): void
+    public function finish(string $message, ?string $extraMessage = null): void
     {
         if (! $this->started) throw new LogicException('Progress indicator has not yet been started.');
 
@@ -91,6 +92,7 @@ public function finish(string $message): void
 
         $this->currentFrame = 5;
         $this->message = $message;
+        $this->extraMessage = $extraMessage;
         $this->render();
         $this->output->writeln('');
         $this->started = false;
@@ -114,7 +116,13 @@ public function render(): void
             $frame = Styles::blue('⠷');
         }
 
-        $line = ' ' . $frame . ' ' . $this->message . Styles::gray(' › ' . $this->formatTime(time() - $this->startTime));
+        $timeFormatted = $this->formatTime(time() - $this->startTime);
+        if ($this->extraMessage) {
+            // Finished with success
+            $line = Styles::gray($timeFormatted . ' › ') . $this->message . Styles::gray(' › ') . $this->extraMessage;
+        } else {
+            $line = ' ' . $frame . ' ' . $this->message . Styles::gray(' › ' . $timeFormatted);
+        }
         $this->overwrite($line);
 
         $this->previousMessage = $this->message;

src/Cli/IO.php

@@ -138,9 +138,9 @@ public static function spinError(string $message = 'error'): void
         self::$spinner = null;
     }
 
-    public static function spinSuccess(string $message): void
+    public static function spinSuccess(string $message, ?string $extraMessage = null): void
     {
-        self::$spinner?->finish($message);
+        self::$spinner?->finish($message, $extraMessage);
         self::$spinner = null;
     }
 

src/Commands/Deploy.php

@@ -16,12 +16,10 @@
 use Bref\Cli\Cli\Styles;
 use Bref\Cli\Components\ServerlessFramework;
 use Exception;
-use Revolt\EventLoop;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Question\ChoiceQuestion;
-use Symfony\Component\HttpClient\HttpClient;
 use Symfony\Contracts\HttpClient\Exception\ClientExceptionInterface;
 use Throwable;
 use ZipArchive;
@@ -57,7 +55,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         IO::writeln([
             sprintf("Deploying %s to environment %s", Styles::bold($appName), Styles::bold($environment)),
-            '',
         ]);
 
         IO::spin('creating deployment');
@@ -154,13 +151,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         while (time() - $startTime < 15 * 60) {
             $deployment = $brefCloud->getDeployment($deploymentId);
             if ($deployment['status'] === 'success') {
-                IO::spinSuccess($deployment['message']);
-                if ($deployment['outputs'] ?? null) {
-                    IO::writeln('');
-                    foreach ($deployment['outputs'] as $key => $value) {
-                        IO::writeln("$key: $value");
-                    }
-                }
+                IO::spinSuccess($deployment['message'], $deployment['app_url'] ?? null);
                 return 0;
             }
             if ($deployment['status'] === 'failed') {