Skip to content

Commit 2796b0d

Browse files
authored
Some small bugfixes and updated readme (#7)
* Small bugfixes and cleanup * Updated readme with new extensions * cs * Typo
1 parent c8b6b84 commit 2796b0d

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

Makefile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ php_versions = 72 73 74
44

55
docker-images:
66
PWD=pwd
7+
set -e; \
78
for dir in layers/*; do \
89
for php_version in $(php_versions); do \
910
echo "###############################################"; \
@@ -21,6 +22,7 @@ layers: docker-images
2122
PWD=pwd
2223
rm -rf export/layer-*.zip || true
2324
mkdir export/tmp
25+
set -e; \
2426
for dir in layers/*; do \
2527
for php_version in $(php_versions); do \
2628
echo "###############################################"; \

Readme.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,13 @@ extension=/opt/bref-extra/amqp.so
3939
| ---- | ----------------------------| -------------- |
4040
| AMQP | `${bref:extra.amqp-php-74}` | `extension=/opt/bref-extra/amqp.so` |
4141
| Blackfire | `${bref:extra.blackfire-php-74}` | `extension=/opt/bref-extra/blackfire.so` |
42+
| GMP | `${bref:extra.gmp-php-74}` | `extension=/opt/bref-extra/gmp.so` |
43+
| Memcache | `${bref:extra.memcached-php-74}` | `extension=/opt/bref-extra/memcache.so` |
44+
| Memcached | `${bref:extra.memcached-php-74}` | `extension=/opt/bref-extra/memcached.so` |
4245
| Xdebug | `${bref:extra.xdebug-php-74}` | `zend_extension=/opt/bref-extra/xdebug.so` |
4346

47+
Note that the "Memcached" layer provides both extension for [Memcache](https://pecl.php.net/package/memcache) and [Memcached](https://pecl.php.net/package/memcached).
48+
4449
## Deploy new versions
4550

4651
```

src/Aws/LayerProvider.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
namespace Bref\Extra\Aws;
44

55
use Aws\Lambda\LambdaClient;
6+
use function GuzzleHttp\Promise\unwrap;
67

78
/**
89
* Fetches layers and details from AWS
@@ -25,7 +26,6 @@ public function __construct(array $layerNames, string $awsId)
2526
$this->layerNames = $layerNames;
2627
}
2728

28-
2929
public function listLayers(string $selectedRegion): array
3030
{
3131
$lambda = new LambdaClient([
@@ -49,8 +49,10 @@ public function listLayers(string $selectedRegion): array
4949
$layers = [];
5050
foreach ($results as $layerName => $result) {
5151
$versions = $result['LayerVersions'];
52-
$latestVersion = end($versions);
53-
$layers[$layerName] = $latestVersion['Version'];
52+
if (! empty($versions)) {
53+
$latestVersion = end($versions);
54+
$layers[$layerName] = $latestVersion['Version'];
55+
}
5456
}
5557

5658
return $layers;

0 commit comments

Comments
 (0)