Merge pull request #1 from fredericDelaporte/hana

Adjust code according to review

Author: breglerj

src/NHibernate.Config.Templates/HANA.cfg.xml

@@ -7,8 +7,11 @@ for your own use before compile tests in VisualStudio.
 <hibernate-configuration  xmlns="urn:nhibernate-configuration-2.2" >
 	<session-factory name="NHibernate.Test">
 		<property name="connection.driver_class">NHibernate.Driver.HanaDriver</property>
+		<!-- Sap.Data.Hana does not support re-enlisting in the same transaction, wrecking many usages
+		     with NHibernate when both NHibernate and the connection performs auto-enlistment. -->
 		<property name="connection.connection_string">
-			Server=localhost:39015;UserID=nhibernate;Password=
+			Server=localhost:39015;UserID=nhibernate;Password=;
+			Enlist=false;
 		</property>
 		<property name="dialect">NHibernate.Dialect.HanaColumnStoreDialect</property>
 	</session-factory>

src/NHibernate.Test/Ado/GenericBatchingBatcherFixture.cs

@@ -29,7 +29,7 @@ protected override bool AppliesTo(Dialect.Dialect dialect)
 			return !(dialect is FirebirdDialect) &&
 			       !(dialect is Oracle8iDialect) &&
 			       !(dialect is MsSqlCeDialect) &&
-			       !(dialect is AbstractHanaDialect);
+			       !(dialect is HanaDialectBase);
 		}
 
 		[Test]

src/NHibernate.Test/Async/Ado/GenericBatchingBatcherFixture.cs

@@ -42,7 +42,7 @@ protected override bool AppliesTo(Dialect.Dialect dialect)
 			return !(dialect is FirebirdDialect) &&
 			       !(dialect is Oracle8iDialect) &&
 			       !(dialect is MsSqlCeDialect) &&
-			       !(dialect is AbstractHanaDialect);
+			       !(dialect is HanaDialectBase);
 		}
 
 		[Test]

src/NHibernate.Test/Async/Criteria/Lambda/FunctionsIntegrationFixture.cs

@@ -19,11 +19,6 @@ namespace NHibernate.Test.Criteria.Lambda
 	[TestFixture]
 	public class FunctionsIntegrationFixtureAsync : TestCase
 	{
-		protected override bool AppliesTo(Dialect.Dialect dialect)
-		{
-			return TestDialect.SupportsEmptyInsertsOrHasNonIdentityNativeGenerator;
-		}
-
 		protected override string MappingsAssembly => "NHibernate.Test";
 
 		protected override IList Mappings => new[] { "Criteria.Lambda.Mappings.hbm.xml" };

src/NHibernate.Test/Async/Criteria/Lambda/IntegrationFixture.cs

@@ -24,11 +24,6 @@ namespace NHibernate.Test.Criteria.Lambda
 	[TestFixture]
 	public class IntegrationFixtureAsync : TestCase
 	{
-		protected override bool AppliesTo(Dialect.Dialect dialect)
-		{
-			return TestDialect.SupportsEmptyInsertsOrHasNonIdentityNativeGenerator;
-		}
-
 		protected override string MappingsAssembly { get { return "NHibernate.Test"; } }
 
 		protected override IList Mappings
@@ -269,6 +264,9 @@ public async Task IsTypeAsync()
 		[Test]
 		public async Task OverrideEagerJoinAsync()
 		{
+			if (!TestDialect.SupportsEmptyInsertsOrHasNonIdentityNativeGenerator)
+				Assert.Ignore("Support of empty inserts is required");
+
 			using (ISession s = OpenSession())
 			using (ITransaction t = s.BeginTransaction())
 			{

src/NHibernate.Test/Async/Criteria/Lambda/ProjectIntegrationFixture.cs

@@ -20,11 +20,6 @@ namespace NHibernate.Test.Criteria.Lambda
 	[TestFixture]
 	public class ProjectIntegrationFixtureAsync : TestCase
 	{
-		protected override bool AppliesTo(Dialect.Dialect dialect)
-		{
-			return TestDialect.SupportsEmptyInsertsOrHasNonIdentityNativeGenerator;
-		}
-
 		protected override string MappingsAssembly
 		{
 			get { return "NHibernate.Test"; }

src/NHibernate.Test/Async/Criteria/Lambda/SimpleIntegrationFixture.cs

@@ -17,11 +17,6 @@ namespace NHibernate.Test.Criteria.Lambda
 	[TestFixture]
 	public class SimpleIntegrationFixtureAsync : TestCase
 	{
-		protected override bool AppliesTo(Dialect.Dialect dialect)
-		{
-			return TestDialect.SupportsEmptyInsertsOrHasNonIdentityNativeGenerator;
-		}
-
 		protected override string MappingsAssembly
 		{
 			get { return "NHibernate.Test"; }

src/NHibernate.Test/Async/Criteria/Lambda/SubQueryIntegrationFixture.cs

@@ -19,11 +19,6 @@ namespace NHibernate.Test.Criteria.Lambda
 	[TestFixture]
 	public class SubQueryIntegrationFixtureAsync : TestCase
 	{
-		protected override bool AppliesTo(Dialect.Dialect dialect)
-		{
-			return TestDialect.SupportsEmptyInsertsOrHasNonIdentityNativeGenerator;
-		}
-
 		protected override string MappingsAssembly
 		{
 			get { return "NHibernate.Test"; }

src/NHibernate.Test/Async/Generatedkeys/Seqidentity/SequenceIdentityFixture.cs

@@ -29,7 +29,7 @@ protected override string MappingsAssembly
 
 		protected override bool AppliesTo(Dialect.Dialect dialect)
 		{
-			return dialect.SupportsSequences && !(dialect is Dialect.MsSql2012Dialect) && !(dialect is Dialect.AbstractHanaDialect);
+			return dialect.SupportsSequences && !(dialect is Dialect.MsSql2012Dialect) && !(dialect is Dialect.HanaDialectBase);
 		}
 
 		[Test]

src/NHibernate.Test/Async/GenericTest/Overall/Fixture.cs

@@ -11,6 +11,7 @@
 using System;
 using System.Collections;
 using System.Collections.Generic;
+
 using NUnit.Framework;
 
 namespace NHibernate.Test.GenericTest.Overall
@@ -19,11 +20,6 @@ namespace NHibernate.Test.GenericTest.Overall
 	[TestFixture]
 	public class FixtureAsync : TestCase
 	{
-		protected override bool AppliesTo(Dialect.Dialect dialect)
-		{
-			return TestDialect.SupportsEmptyInsertsOrHasNonIdentityNativeGenerator;
-		}
-
 		protected override IList Mappings
 		{
 			get { return new[] { "GenericTest.Overall.Mappings.hbm.xml" }; }
@@ -57,6 +53,9 @@ public async Task CRUDAsync()
 		[Test]
 		public async Task CRUDABAsync()
 		{
+			if (!TestDialect.SupportsEmptyInsertsOrHasNonIdentityNativeGenerator)
+				Assert.Ignore("Support of empty inserts is required");
+
 			var entity = new A<B>
 			{
 				Property = new B { Prop = 2 },