Skip to content

Commit b169816

Browse files
Adjust some more code according to review
Do some more reformatting, fix some more tab/spaces mixup.
1 parent 6186110 commit b169816

File tree

26 files changed

+168
-203
lines changed

26 files changed

+168
-203
lines changed

src/NHibernate.Test/Ado/GenericBatchingBatcherFixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ protected override bool AppliesTo(Dialect.Dialect dialect)
2929
return !(dialect is FirebirdDialect) &&
3030
!(dialect is Oracle8iDialect) &&
3131
!(dialect is MsSqlCeDialect) &&
32-
!(dialect is AbstractHanaDialect);
32+
!(dialect is HanaDialectBase);
3333
}
3434

3535
[Test]

src/NHibernate.Test/Async/Ado/GenericBatchingBatcherFixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ protected override bool AppliesTo(Dialect.Dialect dialect)
4242
return !(dialect is FirebirdDialect) &&
4343
!(dialect is Oracle8iDialect) &&
4444
!(dialect is MsSqlCeDialect) &&
45-
!(dialect is AbstractHanaDialect);
45+
!(dialect is HanaDialectBase);
4646
}
4747

4848
[Test]

src/NHibernate.Test/Async/Generatedkeys/Seqidentity/SequenceIdentityFixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ protected override string MappingsAssembly
2929

3030
protected override bool AppliesTo(Dialect.Dialect dialect)
3131
{
32-
return dialect.SupportsSequences && !(dialect is Dialect.MsSql2012Dialect) && !(dialect is Dialect.AbstractHanaDialect);
32+
return dialect.SupportsSequences && !(dialect is Dialect.MsSql2012Dialect) && !(dialect is Dialect.HanaDialectBase);
3333
}
3434

3535
[Test]

src/NHibernate.Test/Async/Hql/HQLFunctions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -947,7 +947,7 @@ public async Task CastAsync()
947947
throw;
948948
}
949949
}
950-
else if (Dialect is AbstractHanaDialect)
950+
else if (Dialect is HanaDialectBase)
951951
{
952952
string msgToCheck =
953953
"not a GROUP BY expression: 'ANIMAL0_.BODYWEIGHT' must be in group by clause";

src/NHibernate.Test/Async/NHSpecificTest/ListsWithHoles/Fixture.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ namespace NHibernate.Test.NHSpecificTest.ListsWithHoles
1818
[TestFixture]
1919
public class FixtureAsync : TestCase
2020
{
21-
protected override bool AppliesTo(Dialect.Dialect dialect)
22-
{
23-
return TestDialect.SupportsEmptyInsertsOrHasNonIdentityNativeGenerator;
24-
}
21+
protected override bool AppliesTo(Dialect.Dialect dialect)
22+
{
23+
return TestDialect.SupportsEmptyInsertsOrHasNonIdentityNativeGenerator;
24+
}
2525

26-
protected override IList Mappings
26+
protected override IList Mappings
2727
{
2828
get { return new string[] { "NHSpecificTest.ListsWithHoles.Mappings.hbm.xml" }; }
2929
}

src/NHibernate.Test/Async/NHSpecificTest/LoadingNullEntityInSet/Fixture.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ protected override string MappingsAssembly
3232
get { return "NHibernate.Test"; }
3333
}
3434

35-
protected override bool AppliesTo(Dialect.Dialect dialect)
36-
{
37-
return TestDialect.SupportsEmptyInsertsOrHasNonIdentityNativeGenerator;
35+
protected override bool AppliesTo(Dialect.Dialect dialect)
36+
{
37+
return TestDialect.SupportsEmptyInsertsOrHasNonIdentityNativeGenerator;
3838
}
3939

4040
protected override DebugSessionFactory BuildSessionFactory()

src/NHibernate.Test/Async/NHSpecificTest/NH1601/Fixture1.cs

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -17,27 +17,27 @@ namespace NHibernate.Test.NHSpecificTest.NH1601
1717
[TestFixture]
1818
public class Fixture1Async : BugTestCase
1919
{
20-
protected override bool AppliesTo(Dialect.Dialect dialect)
21-
{
22-
return TestDialect.SupportsEmptyInsertsOrHasNonIdentityNativeGenerator;
23-
}
24-
25-
/// <summary>
26-
/// Loads the project do not call Count on the list assigned.
27-
/// </summary>
28-
[Test]
20+
protected override bool AppliesTo(Dialect.Dialect dialect)
21+
{
22+
return TestDialect.SupportsEmptyInsertsOrHasNonIdentityNativeGenerator;
23+
}
24+
25+
/// <summary>
26+
/// Loads the project do not call Count on the list assigned.
27+
/// </summary>
28+
[Test]
2929
public Task TestSaveAndLoadWithoutCountAsync()
30-
{
31-
try
32-
{
33-
ProjectWithOneList.TestAccessToList = false;
34-
return SaveAndLoadProjectWithOneListAsync();
35-
}
36-
catch (System.Exception ex)
37-
{
38-
return Task.FromException<object>(ex);
39-
}
40-
}
30+
{
31+
try
32+
{
33+
ProjectWithOneList.TestAccessToList = false;
34+
return SaveAndLoadProjectWithOneListAsync();
35+
}
36+
catch (System.Exception ex)
37+
{
38+
return Task.FromException<object>(ex);
39+
}
40+
}
4141

4242
/// <summary>
4343
/// Refreshes the project do not call Count on the list assigned.

src/NHibernate.Test/Async/NHSpecificTest/NH1601/Fixture2.cs

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -17,27 +17,27 @@ namespace NHibernate.Test.NHSpecificTest.NH1601
1717
[TestFixture]
1818
public class Fixture2Async : BugTestCase
1919
{
20-
protected override bool AppliesTo(Dialect.Dialect dialect)
21-
{
22-
return TestDialect.SupportsEmptyInsertsOrHasNonIdentityNativeGenerator;
23-
}
24-
25-
/// <summary>
26-
/// Loads the project and when Scenario2 and Scenario3 are set calls Count on the list assigned.
27-
/// </summary>
28-
[Test]
20+
protected override bool AppliesTo(Dialect.Dialect dialect)
21+
{
22+
return TestDialect.SupportsEmptyInsertsOrHasNonIdentityNativeGenerator;
23+
}
24+
25+
/// <summary>
26+
/// Loads the project and when Scenario2 and Scenario3 are set calls Count on the list assigned.
27+
/// </summary>
28+
[Test]
2929
public Task TestSaveAndLoadWithTwoCountsAsync()
30-
{
31-
try
32-
{
33-
Project.TestAccessToList = false;
34-
return SaveAndLoadProjectAsync();
35-
}
36-
catch (System.Exception ex)
37-
{
38-
return Task.FromException<object>(ex);
39-
}
40-
}
30+
{
31+
try
32+
{
33+
Project.TestAccessToList = false;
34+
return SaveAndLoadProjectAsync();
35+
}
36+
catch (System.Exception ex)
37+
{
38+
return Task.FromException<object>(ex);
39+
}
40+
}
4141

4242
/// <summary>
4343
/// Refreshes the project and when Scenario2 and Scenario3 are set calls Count on the list assigned.

src/NHibernate.Test/Async/NHSpecificTest/NH623/Fixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public override string BugNumber
2626

2727
protected override bool AppliesTo(Dialect.Dialect dialect)
2828
{
29-
return !(dialect is AbstractHanaDialect); // The WHERE clause "isactive = '1'" doesn't work on HANA because idactive is a boolean
29+
return !(dialect is HanaDialectBase); // The WHERE clause "isactive = '1'" doesn't work on HANA because idactive is a boolean
3030
}
3131

3232
private ISession session;

src/NHibernate.Test/DialectTest/FunctionTests/SubstringSupportFixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public void DialectShouldUseCorrectSubstringImplementation(System.Type dialectTy
4949
break;
5050
case Oracle8iDialect _:
5151
case SQLiteDialect _:
52-
case AbstractHanaDialect _:
52+
case HanaDialectBase _:
5353
Assert.That(substringFunction, Is.TypeOf<StandardSQLFunction>());
5454
break;
5555
default:

0 commit comments

Comments
 (0)