Skip to content

Commit d5969ce

Browse files
committed
Minor fixes addressing PR comments for SAP HANA support
- Replace explicit check for AbstractHanaDialect with TestDialect.SupportsEmptyInserts where applicable - Replace copied base class documentation with <inheritdoc /> - Add constructor SQLFunctionTemplateWithRequiredParameters(IType, string, object[], bool) - Improve documentation of SQLFunctionTemplateWithRequiredParameters - Removed deprecation comments from Dialect#AddColumnString and Dialect#AddColumnSuffixString
1 parent 34a46e3 commit d5969ce

File tree

104 files changed

+176
-451
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

104 files changed

+176
-451
lines changed

src/NHibernate.Test/Async/Criteria/Lambda/FunctionsIntegrationFixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public class FunctionsIntegrationFixtureAsync : TestCase
2222
{
2323
protected override bool AppliesTo(Dialect.Dialect dialect)
2424
{
25-
return !(dialect is AbstractHanaDialect); // HANA does not support inserting a row without specifying any column values
25+
return TestDialect.SupportsEmptyInserts;
2626
}
2727

2828
protected override string MappingsAssembly => "NHibernate.Test";

src/NHibernate.Test/Async/Criteria/Lambda/IntegrationFixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public class IntegrationFixtureAsync : TestCase
2727
{
2828
protected override bool AppliesTo(Dialect.Dialect dialect)
2929
{
30-
return !(dialect is AbstractHanaDialect); // HANA does not support inserting a row without specifying any column values
30+
return TestDialect.SupportsEmptyInserts;
3131
}
3232

3333
protected override string MappingsAssembly { get { return "NHibernate.Test"; } }

src/NHibernate.Test/Async/Criteria/Lambda/ProjectIntegrationFixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public class ProjectIntegrationFixtureAsync : TestCase
2323
{
2424
protected override bool AppliesTo(Dialect.Dialect dialect)
2525
{
26-
return !(dialect is AbstractHanaDialect); // HANA does not support inserting a row without specifying any column values
26+
return TestDialect.SupportsEmptyInserts;
2727
}
2828

2929
protected override string MappingsAssembly

src/NHibernate.Test/Async/Criteria/Lambda/SimpleIntegrationFixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public class SimpleIntegrationFixtureAsync : TestCase
2020
{
2121
protected override bool AppliesTo(Dialect.Dialect dialect)
2222
{
23-
return !(dialect is AbstractHanaDialect); // HANA does not support inserting a row without specifying any column values
23+
return TestDialect.SupportsEmptyInserts;
2424
}
2525

2626
protected override string MappingsAssembly

src/NHibernate.Test/Async/Criteria/Lambda/SubQueryIntegrationFixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public class SubQueryIntegrationFixtureAsync : TestCase
2222
{
2323
protected override bool AppliesTo(Dialect.Dialect dialect)
2424
{
25-
return !(dialect is AbstractHanaDialect); // HANA does not support inserting a row without specifying any column values
25+
return TestDialect.SupportsEmptyInserts;
2626
}
2727

2828
protected override string MappingsAssembly

src/NHibernate.Test/Async/Events/Collections/AbstractCollectionEventFixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public abstract class AbstractCollectionEventFixtureAsync : TestCase
2626
{
2727
protected override bool AppliesTo(Dialect.Dialect dialect)
2828
{
29-
return !(dialect is AbstractHanaDialect); // HANA does not support inserting a row without specifying any column values
29+
return TestDialect.SupportsEmptyInserts;
3030
}
3131

3232
protected override string MappingsAssembly

src/NHibernate.Test/Async/GenericTest/Overall/Fixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public class FixtureAsync : TestCase
2222
{
2323
protected override bool AppliesTo(Dialect.Dialect dialect)
2424
{
25-
return !(dialect is AbstractHanaDialect); // HANA does not support inserting a row without specifying any column values
25+
return TestDialect.SupportsEmptyInserts;
2626
}
2727

2828
protected override IList Mappings

src/NHibernate.Test/Async/Legacy/FooBarTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ private static byte[] GetBytes(string str)
4444

4545
protected override bool AppliesTo(Dialect.Dialect dialect)
4646
{
47-
return !(dialect is AbstractHanaDialect); // HANA does not support inserting a row without specifying any column values
47+
return TestDialect.SupportsEmptyInserts;
4848
}
4949

5050
protected override IList Mappings

src/NHibernate.Test/Async/Legacy/FumTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public class FumTestAsync : TestCase
3232

3333
protected override bool AppliesTo(Dialect.Dialect dialect)
3434
{
35-
return !(dialect is AbstractHanaDialect); // HANA does not support inserting a row without specifying any column values
35+
return TestDialect.SupportsEmptyInserts;
3636
}
3737

3838
protected override IList Mappings

src/NHibernate.Test/Async/Legacy/MasterDetailTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public class MasterDetailTestAsync : TestCase
3232
{
3333
protected override bool AppliesTo(Dialect.Dialect dialect)
3434
{
35-
return !(dialect is AbstractHanaDialect); // HANA does not support inserting a row without specifying any column values
35+
return TestDialect.SupportsEmptyInserts;
3636
}
3737

3838
protected override IList Mappings

0 commit comments

Comments
 (0)