Ensure that _nanmean_mapreduce! inserts nans for zero counts#60
Merged
brenhinkeller merged 1 commit intobrenhinkeller:mainfrom May 27, 2025
Merged
Conversation
Also added some more tests for `nansum`.
Owner
|
Ah yeah, |
| B[i] = nan_value | ||
| else | ||
| B[i] /= counts[i] | ||
| end |
Owner
There was a problem hiding this comment.
This can be a problem for later, but I think you can probably avoid the branch entirely and just still use B[i] /= counts[i] since 0/0 is NaN
Contributor
Author
There was a problem hiding this comment.
Ah cool, I didn't realize that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added some more tests for
nansum. In doing so I noticed thatnansumwill always give 0 instead of nan, which always annoyed me in numpy 😛 Maybe we could change that in a later version? It'd be breaking though, and if people expect that behaviour then we'd need a way to opt in/out.Fixes #59.