Skip to content

Commit c300eb2

Browse files
committed
bump versions and fix #216
closes #216
1 parent 8696b5b commit c300eb2

File tree

3 files changed

+15
-15
lines changed

3 files changed

+15
-15
lines changed

functional-tests.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,15 +67,15 @@ assert_equal "MT 0 80 1 MT 80 16569 0 " "$(zgrep ^MT t.per-base.bed.gz | tr -s '
6767

6868
run length_filter $exe t tests/ovl.bam --min-frag-len 81
6969
assert_exit_code 0
70-
assert_equal "MT 0 16569 0" "$(zgrep ^MT t.per-base.bed.gz)"
70+
assert_equal "MT 0 16569 0" "$(zgrep ^MT t.per-base.bed.gz)"
7171

7272
run length_filter $exe t tests/ovl.bam --max-frag-len 79
7373
assert_exit_code 0
74-
assert_equal "MT 0 16569 0" "$(zgrep ^MT t.per-base.bed.gz)"
74+
assert_equal "MT 0 16569 0" "$(zgrep ^MT t.per-base.bed.gz)"
7575

7676
run bad_frag_len_filter $exe t tests/ovl.bam --min-frag-len 10 --max-frag-len 9
7777
assert_in_stderr "--max-frag-len was lower than --min-frag-len."
78-
assert_exit_code 1
78+
assert_exit_code 2
7979

8080

8181
unset MOSDEPTH_Q0

mosdepth.nim

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ proc write_thresholds(fh:BGZI, tid:int, arr:var coverage_t, thresholds:seq[int],
498498
if tid == -2:
499499
for i in thresholds:
500500
line.add("\t0")
501-
discard fh.write_interval(line, region.chrom, start, stop)
501+
doAssert fh.write_interval(line, region.chrom, start, stop) >= 0
502502
return
503503

504504
var counts = new_seq[int](len(thresholds))
@@ -513,13 +513,13 @@ proc write_thresholds(fh:BGZI, tid:int, arr:var coverage_t, thresholds:seq[int],
513513

514514
for count in counts:
515515
line.add("\t" & intToStr(count))
516-
discard fh.write_interval(line, region.chrom, start, stop)
516+
doAssert fh.write_interval(line, region.chrom, start, stop) >= 0
517517

518518
proc write_header(fh:BGZI, thresholds: seq[int]) =
519-
discard fh.bgz.write("#chrom start end region")
519+
doAssert fh.bgz.write("#chrom start end region") >= 0
520520
for threshold in thresholds:
521-
discard fh.bgz.write("\t" & intToStr(threshold) & "X")
522-
discard fh.bgz.write("\n")
521+
doAssert fh.bgz.write("\t" & intToStr(threshold) & "X") >= 0
522+
doAssert fh.bgz.write("\n") >= 0
523523

524524
proc get_min_levels(targets: seq[Target]): int =
525525
# determine how many levels are needed to store the data given
@@ -658,7 +658,7 @@ proc main(bam: hts.Bam, chrom: region_t, mapq: int, min_len: int, max_len: int,
658658
line.add(starget & intToStr(int(r.start)) & "\t" & intToStr(int(r.stop)) & "\t" & m)
659659
else:
660660
line.add(starget & intToStr(int(r.start)) & "\t" & intToStr(int(r.stop)) & "\t" & r.name & "\t" & m)
661-
discard fregion.write_interval(line, target.name, int(r.start), int(r.stop))
661+
doAssert fregion.write_interval(line, target.name, int(r.start), int(r.stop)) >= 0
662662
line = line[0..<0]
663663
if tid != -2:
664664
if region.isdigit: #stores the aggregated coverage for each region when working with even windows across the genome
@@ -694,7 +694,7 @@ proc main(bam: hts.Bam, chrom: region_t, mapq: int, min_len: int, max_len: int,
694694
if use_d4:
695695
fd4.write(target.name, @[Interval(left: 0'u32, right: target.length.uint32, value: 0'i32)])
696696
else:
697-
discard fbase.write_interval(starget & "0\t" & intToStr(int(target.length)) & "\t0", target.name, 0, int(target.length))
697+
doAssert fbase.write_interval(starget & "0\t" & intToStr(int(target.length)) & "\t0", target.name, 0, int(target.length)) >= 0
698698
else:
699699
var write_fbase = true
700700
when defined(d4):
@@ -713,15 +713,15 @@ proc main(bam: hts.Bam, chrom: region_t, mapq: int, min_len: int, max_len: int,
713713
fastIntToStr(p.stop.int32, line, line.len)
714714
line.add('\t')
715715
fastIntToStr(p.value.int32, line, line.len)
716-
discard fbase.write_interval(line, target.name, p.start, p.stop)
716+
doAssert fbase.write_interval(line, target.name, p.start, p.stop) >= 0
717717
if quantize.len != 0:
718718
if tid == -2 and quantize[0] == 0:
719719
var lookup = make_lookup(quantize)
720-
discard fquantize.write_interval(starget & "0\t" & intToStr(int(target.length)) & "\t" & lookup[0], target.name, 0, int(target.length))
720+
doAssert fquantize.write_interval(starget & "0\t" & intToStr(int(target.length)) & "\t" & lookup[0], target.name, 0, int(target.length)) >= 0
721721
else:
722722
if tid == -2: continue
723723
for p in gen_quantized(quantize, arr):
724-
discard fquantize.write_interval(starget & intToStr(p.start) & "\t" & intToStr(p.stop) & "\t" & p.value, target.name, p.start, p.stop)
724+
doAssert fquantize.write_interval(starget & intToStr(p.start) & "\t" & intToStr(p.stop) & "\t" & p.value, target.name, p.start, p.stop) >= 0
725725

726726
write_summary("total", global_stat, fh_summary)
727727
if region != "":
@@ -782,7 +782,7 @@ when(isMainModule):
782782
when not defined(release) and not defined(lto):
783783
stderr.write_line "[mosdepth] WARNING: built in debug mode; will be slow"
784784

785-
let version = "mosdepth 0.3.5"
785+
let version = "mosdepth 0.3.6"
786786
let env_fasta = getEnv("REF_PATH")
787787
var doc = format("""
788788
$version

mosdepth.nimble

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Package
22

3-
version = "0.3.5"
3+
version = "0.3.6"
44
author = "Brent Pedersen"
55
description = "fast depth"
66
license = "MIT"

0 commit comments

Comments
 (0)