Skip to content

Fix the ls help syntax to denote org name should be used, not ID #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nwmitchell wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix the ls help syntax to denote org name should be used, not ID #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9ee5ff
Fix the `ls` help syntax to denote org name should be used, not ID
nwmitchell Mar 26, 2025
2e08cc0
Fix CI
nwmitchell Mar 31, 2025
752a74f
Update upload-artifact to v4
nwmitchell Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/fmt.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:


- name: install
run: make install
run: make install-tools
- name: check fmt
run: make fmtcheck
# - name: Report Status
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/legacy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ jobs:
- name: Build
run: make ci
- name: Upload coverage
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: coverage
path: coverage.*

- name: Upload dist
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: dist
path: dist
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
go-version: '1.22.6'
cache: true
- name: install
run: make install
run: make install-tools
- name: lint
run: make lint
# - name: Report Status
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,17 @@ jobs:
go-version: '1.22.6'
cache: true
- name: install
run: make install
run: make install-tools
- name: test
run: make test
- name: Upload coverage
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: coverage
path: coverage.*

- name: Upload dist
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: dist
path: dist
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/vet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
go-version: '1.22.6'
cache: true
- name: install
run: make install
run: make install-tools
- name: vet
run: make vet
# - name: Report Status
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/ls/ls.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ func NewCmdLs(t *terminal.Terminal, loginLsStore LsStore, noLoginLsStore LsStore
Example: `
brev ls
brev ls orgs
brev ls --org <orgid>
brev ls --org <name>
`,
PersistentPostRunE: func(cmd *cobra.Command, args []string) error {
if hello.ShouldWeRunOnboardingLSStep(noLoginLsStore) && hello.ShouldWeRunOnboarding(noLoginLsStore) {
Expand Down
Loading