Fix Analysis Errors

Author: brianegan

bloc_library/lib/screens/home_screen.dart

@@ -8,6 +8,8 @@ import 'package:flutter_bloc/flutter_bloc.dart';
 import 'package:todos_app_core/todos_app_core.dart';
 
 class HomeScreen extends StatelessWidget {
+  const HomeScreen({super.key});
+
   @override
   Widget build(BuildContext context) {
     final tabBloc = BlocProvider.of<TabBloc>(context);

bloc_library/lib/widgets/extra_actions.dart

@@ -6,7 +6,7 @@ import 'package:flutter_bloc/flutter_bloc.dart';
 import 'package:todos_app_core/todos_app_core.dart';
 
 class ExtraActions extends StatelessWidget {
-  ExtraActions({super.key = ArchSampleKeys.extraActionsButton});
+  const ExtraActions({super.key = ArchSampleKeys.extraActionsButton});
 
   @override
   Widget build(BuildContext context) {

bloc_library/lib/widgets/filter_button.dart

@@ -7,7 +7,7 @@ import 'package:todos_app_core/todos_app_core.dart';
 class FilterButton extends StatelessWidget {
   final bool visible;
 
-  FilterButton({super.key, required this.visible});
+  const FilterButton({super.key, required this.visible});
 
   @override
   Widget build(BuildContext context) {

bloc_library/test/blocs/todos_bloc_test.dart

@@ -95,7 +95,6 @@ void main() {
           ..add(AddTodo(todo1))
           ..add(AddTodo(todo2))
           ..add(ClearCompleted());
-        ;
       },
       expect: () => [
         TodosLoaded([]),
@@ -119,7 +118,6 @@ void main() {
           ..add(AddTodo(todo1))
           ..add(AddTodo(todo2))
           ..add(ToggleAll());
-        ;
       },
       expect: () => [
         TodosLoaded([]),
@@ -146,7 +144,6 @@ void main() {
           ..add(AddTodo(todo1))
           ..add(AddTodo(todo2))
           ..add(ToggleAll());
-        ;
       },
       expect: () => [
         TodosLoaded([]),

bloc_library/test/screens/add_edit_screen_test.dart

@@ -37,7 +37,7 @@ void main() {
       await tester.pumpWidget(
         MaterialApp(
           home: Scaffold(
-            body: AddEditScreen(isEditing: false, onSave: (_, __) {}),
+            body: AddEditScreen(isEditing: false, onSave: (_, _) {}),
           ),
           localizationsDelegates: [
             ArchSampleLocalizationsDelegate(),
@@ -59,7 +59,7 @@ void main() {
           home: Scaffold(
             body: AddEditScreen(
               isEditing: true,
-              onSave: (_, __) {
+              onSave: (_, _) {
                 onSavePressed = true;
               },
               todo: Todo('wash dishes'),
@@ -84,7 +84,7 @@ void main() {
           home: Scaffold(
             body: AddEditScreen(
               isEditing: true,
-              onSave: (_, __) {},
+              onSave: (_, _) {},
               todo: Todo('wash dishes'),
             ),
           ),

bloc_library/test/widgets/todo_item_test.dart

@@ -1,9 +1,9 @@
+import 'package:bloc_library/localization.dart';
+import 'package:bloc_library/models/models.dart';
+import 'package:bloc_library/widgets/todo_item.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_test/flutter_test.dart';
-import 'package:bloc_library/localization.dart';
 import 'package:todos_app_core/todos_app_core.dart';
-import 'package:bloc_library/widgets/todo_item.dart';
-import 'package:bloc_library/models/models.dart';
 
 void main() {
   group('TodoItem', () {
@@ -14,9 +14,9 @@ void main() {
         MaterialApp(
           home: Scaffold(
             body: TodoItem(
-              onCheckboxChanged: (_) => null,
-              onDismissed: (_) => null,
-              onTap: () => null,
+              onCheckboxChanged: (_) {},
+              onDismissed: (_) {},
+              onTap: () {},
               todo: Todo('wash car', id: '0'),
             ),
           ),
@@ -39,9 +39,9 @@ void main() {
         MaterialApp(
           home: Scaffold(
             body: TodoItem(
-              onCheckboxChanged: (_) => null,
-              onDismissed: (_) => null,
-              onTap: () => null,
+              onCheckboxChanged: (_) {},
+              onDismissed: (_) {},
+              onTap: () {},
               todo: Todo('wash car', note: 'some note', id: '0'),
             ),
           ),

blocs/lib/blocs.dart

@@ -1,5 +1,3 @@
-library blocs;
-
 export 'src/models/models.dart';
 export 'src/stats_bloc.dart';
 export 'src/todo_bloc.dart';

blocs/lib/src/todo_bloc.dart

@@ -44,6 +44,8 @@ class TodoBloc {
   void close() {
     deleteTodo.close();
     updateTodo.close();
-    _subscriptions.forEach((subscription) => subscription.cancel());
+    for (var subscription in _subscriptions) {
+      subscription.cancel();
+    }
   }
 }

blocs/lib/src/todos_list_bloc.dart

@@ -124,6 +124,8 @@ class TodosListBloc {
     clearCompleted.close();
     toggleAll.close();
     updateTodo.close();
-    _subscriptions.forEach((subscription) => subscription.cancel());
+    for (var subscription in _subscriptions) {
+      subscription.cancel();
+    }
   }
 }

blocs/lib/src/user_bloc.dart

@@ -9,5 +9,5 @@ class UserBloc {
   Stream<UserEntity> login() =>
       _repository.login().asStream().asBroadcastStream();
 
-  UserBloc(UserRepository repository) : this._repository = repository;
+  UserBloc(UserRepository repository) : _repository = repository;
 }