adding / as a valid character (opensearch-project#3854)

* adding / as a valid character

Signed-off-by: Dhrubo Saha <[email protected]>

* fixing unit test

Signed-off-by: Dhrubo Saha <[email protected]>

---------

Signed-off-by: Dhrubo Saha <[email protected]>

Author: dhrubo-os

common/src/main/java/org/opensearch/ml/common/utils/StringUtils.java

@@ -64,10 +64,9 @@ public class StringUtils {
         + "\n    }\n";
 
     // Regex allows letters, digits, spaces, hyphens, underscores, and dots.
-    private static final Pattern SAFE_INPUT_PATTERN = Pattern.compile("^[\\p{L}\\p{N}\\s.,!?():@\\-_'\"]*$");
+    private static final Pattern SAFE_INPUT_PATTERN = Pattern.compile("^[\\p{L}\\p{N}\\s.,!?():@\\-_/'\"]*$");
 
-    public static final String SAFE_INPUT_DESCRIPTION =
-        "can only contain letters, numbers, whitespace, and basic punctuation (.,!?():@-_'\")";
+    public static final String SAFE_INPUT_DESCRIPTION = "can only contain letters, numbers, spaces, and basic punctuation (.,!?():@-_'/\")";
 
     public static final Gson gson;
 

common/src/test/java/org/opensearch/ml/common/transport/connector/MLCreateConnectorRequestTests.java

@@ -258,15 +258,12 @@ public void validateWithEmptyAndInvalidModelConnectorNameAndDescription() {
         String exceptionMessage = invalidException.getMessage();
         assertTrue(
             "Error message should contain name validation failure",
-            exceptionMessage
-                .contains("Model connector name can only contain letters, numbers, whitespace, and basic punctuation (.,!?():@-_'\");")
+            exceptionMessage.contains("Model connector name " + SAFE_INPUT_DESCRIPTION + ";")
         );
+
         assertTrue(
             "Error message should contain description validation failure",
-            exceptionMessage
-                .contains(
-                    "Model connector description can only contain letters, numbers, whitespace, and basic punctuation (.,!?():@-_'\");"
-                )
+            exceptionMessage.contains("Model connector description " + SAFE_INPUT_DESCRIPTION + ";")
         );
     }
 

common/src/test/java/org/opensearch/ml/common/utils/StringUtilsTest.java

@@ -810,7 +810,7 @@ public void testIsSafeText_AdvancedInvalidInputs() {
         // Testing specifically excluded characters
         assertFalse(StringUtils.isSafeText("Hello<World"));  // less than
         assertFalse(StringUtils.isSafeText("Hello>World"));  // greater than
-        assertFalse(StringUtils.isSafeText("Hello/World"));  // forward slash
+        assertTrue(StringUtils.isSafeText("Hello/World"));  // forward slash
         assertFalse(StringUtils.isSafeText("Hello\\World")); // backslash
         assertFalse(StringUtils.isSafeText("Hello&World"));  // ampersand
         assertFalse(StringUtils.isSafeText("Hello+World"));  // plus