GitHub Actions: Add macOS cases.

* Migrate macOS cases in Travis to GitHub Actions.

* Increase the expected time in the test to avoid the following random failures
  on macOS.

  ```
  1) Mysql2::Client#query threaded queries should be supported
     Failure/Error: expect(stop - start).to be_within(0.1).of(sleep_time)
       expected 0.632204999999999 to be within 0.1 of 0.5
     # ./spec/mysql2/client_spec.rb:711:in `block (3 levels) in <top (required)>'
  ```

  ```
  3) Mysql2::Client#query should run signal handlers while waiting for a response
     Failure/Error: expect(mark.fetch(:QUERY_END) - mark.fetch(:QUERY_START)).to be_within(0.1).of(query_time)
       expected 1.1042130000000157 to be within 0.1 of 1.0
     # ./spec/mysql2/client_spec.rb:632:in `block (3 levels) in <top (required)>'
  ```

Author: junaruga

.github/workflows/ubuntu.yml renamed to .github/workflows/build.yml

@@ -1,4 +1,4 @@
-name: Ubuntu
+name: Build
 on: [push, pull_request]
 jobs:
   build:
@@ -38,6 +38,12 @@ jobs:
           # `service mysql restart` fails.
           - {os: ubuntu-20.04, ruby: 2.4, db: mysql80, allow-failure: true}
           - {os: ubuntu-18.04, ruby: 'head', db: '', allow-failure: true}
+          # db: the DB's brew package name in macOS case.
+          # Allow failure due to the following test failures.
+          # https://github.com/brianmario/mysql2/issues/965
+          - {os: macos-latest, ruby: 2.4, db: '[email protected]', allow-failure: true}
+          # Allow failure due to Mysql2::Error: Unknown system variable 'session_track_system_variables'.
+          - {os: macos-latest, ruby: 2.4, db: '[email protected]', allow-failure: true}
       # On the fail-fast: true, it cancels all in-progress jobs
       # if any matrix job fails unlike Travis fast_finish.
       fail-fast: false

.travis.yml

@@ -49,14 +49,5 @@ matrix:
       addons:
         hosts:
           - mysql2gem.example.com
-    - os: osx
-      rvm: 2.4
-      env: DB=mysql56
-      addons:
-        hosts:
-          - mysql2gem.example.com
   fast_finish: true
   allow_failures:
-    - os: osx
-      rvm: 2.4
-      env: DB=mysql56

.travis_setup.sh

@@ -76,11 +76,23 @@ if [[ -n ${GITHUB_ACTIONS-} && -n ${DB-} && x$DB =~ ^xmariadb10.3 ]]; then
   CHANGED_PASSWORD=true
 fi
 
-# Install MySQL if OS=darwin
+# Install MySQL/MariaDB if OS=darwin
 if [[ x$OSTYPE =~ ^xdarwin ]]; then
-  brew update
+  brew update > /dev/null
+
+  # Check available packages.
+  for KEYWORD in mysql mariadb; do
+    brew search "${KEYWORD}"
+  done
+
   brew install "$DB" mariadb-connector-c
-  $(brew --prefix "$DB")/bin/mysql.server start
+  DB_PREFIX="$(brew --prefix "${DB}")"
+  export PATH="${DB_PREFIX}/bin:${PATH}"
+  export LDFLAGS="-L${DB_PREFIX}/lib"
+  export CPPFLAGS="-I${DB_PREFIX}/include"
+
+  mysql.server start
+  CHANGED_PASSWORD_BY_RECREATE=true
 fi
 
 # TODO: get SSL working on OS X in Travis
@@ -89,13 +101,11 @@ if ! [[ x$OSTYPE =~ ^xdarwin ]]; then
   sudo service mysql restart
 fi
 
-# Print the MySQL version and create the test DB
-if [[ x$OSTYPE =~ ^xdarwin ]]; then
-  $(brew --prefix "$DB")/bin/mysqld --version
-  $(brew --prefix "$DB")/bin/mysql -u root -e 'CREATE DATABASE IF NOT EXISTS test'
-else
-  mysqld --version
+mysqld --version
 
+MYSQL_OPTS=''
+DB_SYS_USER=root
+if ! [[ x$OSTYPE =~ ^xdarwin ]]; then
   if [[ -n ${GITHUB_ACTIONS-} && -f /etc/mysql/debian.cnf ]]; then
     MYSQL_OPTS='--defaults-extra-file=/etc/mysql/debian.cnf'
     # Install from packages in OS official packages.
@@ -106,25 +116,20 @@ else
       # xenial
       DB_SYS_USER=root
     fi
-  else
-    # Install from official mysql packages.
-    MYSQL_OPTS=''
-    DB_SYS_USER=root
   fi
+fi
 
-  if [ "${CHANGED_PASSWORD}" = true ]; then
-    # https://www.percona.com/blog/2016/03/16/change-user-password-in-mysql-5-7-with-plugin-auth_socket/
-    sudo mysql ${MYSQL_OPTS} -u "${DB_SYS_USER}" \
-      -e "ALTER USER 'root'@'localhost' IDENTIFIED WITH mysql_native_password BY ''"
-  elif [ "${CHANGED_PASSWORD_BY_RECREATE}" = true ]; then
-    sudo mysql ${MYSQL_OPTS} -u "${DB_SYS_USER}" <<SQL
+if [ "${CHANGED_PASSWORD}" = true ]; then
+  # https://www.percona.com/blog/2016/03/16/change-user-password-in-mysql-5-7-with-plugin-auth_socket/
+  sudo mysql ${MYSQL_OPTS} -u "${DB_SYS_USER}" \
+    -e "ALTER USER 'root'@'localhost' IDENTIFIED WITH mysql_native_password BY ''"
+elif [ "${CHANGED_PASSWORD_BY_RECREATE}" = true ]; then
+  sudo mysql ${MYSQL_OPTS} -u "${DB_SYS_USER}" <<SQL
 DROP USER 'root'@'localhost';
 CREATE USER 'root'@'localhost' IDENTIFIED BY '';
 GRANT ALL PRIVILEGES ON *.* TO 'root'@'localhost' WITH GRANT OPTION;
 FLUSH PRIVILEGES;
 SQL
-  fi
-
-  # IF NOT EXISTS is mariadb-10+ only - https://mariadb.com/kb/en/mariadb/comment-syntax/
-  mysql -u root -e 'CREATE DATABASE /*M!50701 IF NOT EXISTS */ test'
 fi
+
+mysql -u root -e 'CREATE DATABASE IF NOT EXISTS test'

spec/mysql2/client_spec.rb

@@ -629,7 +629,7 @@ def run_gc
         end
 
         # the query ran uninterrupted
-        expect(mark.fetch(:QUERY_END) - mark.fetch(:QUERY_START)).to be_within(0.1).of(query_time)
+        expect(mark.fetch(:QUERY_END) - mark.fetch(:QUERY_START)).to be_within(0.2).of(query_time)
         # signals fired while the query was running
         expect(mark.fetch(:USR1)).to be_between(mark.fetch(:QUERY_START), mark.fetch(:QUERY_END))
       end
@@ -708,7 +708,7 @@ def run_gc
 
         # This check demonstrates that the threads are sleeping concurrently:
         # In the serial case, the difference would be a multiple of sleep time
-        expect(stop - start).to be_within(0.1).of(sleep_time)
+        expect(stop - start).to be_within(0.2).of(sleep_time)
 
         expect(values).to match_array(threads.map(&:object_id))
       end