Skip to content

Commit 346b4a4

Browse files
authored
Merge pull request #1176 from junaruga/wip/refactor-ci
Refactor CI yaml files
2 parents b439a89 + ec1dac4 commit 346b4a4

File tree

3 files changed

+9
-19
lines changed

3 files changed

+9
-19
lines changed

.github/workflows/build.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
# Run all the tests on the new environment as much as possible.
88
# https://docs.github.com/en/free-pro-team@latest/actions/reference/specifications-for-github-hosted-runners
99
runs-on: ${{ matrix.os }}
10-
continue-on-error: ${{ matrix.allow-failure }}
10+
continue-on-error: ${{ matrix.allow-failure || false }}
1111
strategy:
1212
matrix:
1313
os:
@@ -26,16 +26,15 @@ jobs:
2626
- 2.2
2727
- 2.1
2828
db: ['']
29-
allow-failure: [false]
3029
include:
3130
# Allow failure due to Mysql2::Error: Unknown system variable 'session_track_system_variables'.
3231
- {os: ubuntu-16.04, ruby: 2.4, db: mariadb10.0, allow-failure: true}
3332
# Comment out due to ci/setup.sh stucking.
34-
# - {os: ubuntu-18.04, ruby: 2.4, db: mariadb10.1, allow-failure: false}
35-
# Allow failure due to the issue #1165.
36-
- {os: ubuntu-20.04, ruby: 2.4, db: mariadb10.3, allow-failure: true}
37-
- {os: ubuntu-18.04, ruby: 2.4, db: mysql57, allow-failure: false}
33+
# - {os: ubuntu-18.04, ruby: 2.4, db: mariadb10.1}
3834
# `service mysql restart` fails.
35+
- {os: ubuntu-20.04, ruby: 2.4, db: mariadb10.3, allow-failure: true}
36+
- {os: ubuntu-18.04, ruby: 2.4, db: mysql57}
37+
# Allow failure due to the issue #1165.
3938
- {os: ubuntu-20.04, ruby: 2.4, db: mysql80, allow-failure: true}
4039
- {os: ubuntu-18.04, ruby: 'head', db: '', allow-failure: true}
4140
# db: A DB's brew package name in macOS case.

.github/workflows/container.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,14 @@ on: [push, pull_request]
55
jobs:
66
build:
77
name: >-
8-
${{ matrix.distro }} ${{ matrix.image }}
8+
${{ matrix.distro }} ${{ matrix.image }} ${{ matrix.name_extra || '' }}
99
runs-on: ubuntu-20.04 # focal
10-
continue-on-error: ${{ matrix.allow-failure }}
10+
continue-on-error: ${{ matrix.allow-failure || false }}
1111
strategy:
1212
matrix:
1313
include:
14-
- {distro: centos, image: 'centos:7', allow-failure: false}
14+
# CentOS 7 system Ruby is the fixed version 2.0.0.
15+
- {distro: centos, image: 'centos:7', name_extra: 'ruby 2.0.0'}
1516
# Fedora latest stable version
1617
# Allow failure due to the following test failures.
1718
# https://github.com/brianmario/mysql2/issues/965

.travis.yml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
sudo: required
21
dist: trusty
32
language: ruby
43
bundler_args: --without development
@@ -9,17 +8,8 @@ before_install:
98
- gem update bundler
109
- gem --version
1110
- bash ci/setup.sh
12-
addons:
13-
hosts:
14-
- mysql2gem.example.com
15-
apt:
16-
packages:
17-
- mysql-server-5.6
18-
- mysql-client-core-5.6
19-
- mysql-client-5.6
2011
matrix:
2112
include:
22-
- rvm: 2.0.0
2313
- rvm: 2.4
2414
env: DB=mariadb10.0
2515
addons:

0 commit comments

Comments
 (0)