File tree Expand file tree Collapse file tree 1 file changed +9
-0
lines changed Expand file tree Collapse file tree 1 file changed +9
-0
lines changed Original file line number Diff line number Diff line change @@ -331,6 +331,15 @@ static VALUE each(VALUE self) {
331
331
unsigned long field_count ;
332
332
unsigned long i ;
333
333
334
+ // FIXME we are calling mysql_stmt_store_result() *before* instead of *after*
335
+ // binding the data buffers with mysql_stmt_bind_result(). Turn into a config
336
+ // flag for result sets that require a lot of memory?
337
+ //
338
+ // From MySQL docs:
339
+ // "By default, result sets are fetched unbuffered a row at a time from the
340
+ // server. To buffer the entire result set on the client, call
341
+ // mysql_stmt_store_result() after binding the data buffers and before
342
+ // calling mysql_stmt_fetch()."
334
343
if (mysql_stmt_store_result (stmt )) {
335
344
rb_raise (cMysql2Error , "%s" , mysql_stmt_error (stmt ));
336
345
}
You can’t perform that action at this time.
0 commit comments