Style/NumericPredicate

Author: tamird

.rubocop_todo.yml

@@ -78,16 +78,6 @@ Style/GlobalVars:
 Style/NumericLiterals:
   MinDigits: 20
 
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles.
-# SupportedStyles: predicate, comparison
-Style/NumericPredicate:
-  Exclude:
-    - 'spec/**/*'
-    - 'benchmark/setup_db.rb'
-    - 'lib/mysql2.rb'
-
 # Offense count: 15
 # Cop supports --auto-correct.
 # Configuration parameters: PreferredDelimiters.
@@ -117,11 +107,3 @@ Style/SignalException:
 # SupportedStyles: single_quotes, double_quotes
 Style/StringLiterals:
   Enabled: false
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: all_comparison_operators, equality_operators_only
-Style/YodaCondition:
-  Exclude:
-    - 'lib/mysql2.rb'

benchmark/setup_db.rb

@@ -112,7 +112,7 @@ def insert_record(args)
     enum_test: %w(val1 val2).sample,
     set_test: %w(val1 val2 val1,val2).sample,
   )
-  if n % 100 == 0
+  if (n % 100).zero?
     $stdout.putc '.'
     $stdout.flush
   end

lib/mysql2.rb

@@ -24,7 +24,7 @@
   if dll_path
     require 'Win32API'
     LoadLibrary = Win32API.new('Kernel32', 'LoadLibrary', ['P'], 'I')
-    if 0 == LoadLibrary.call(dll_path)
+    if LoadLibrary.call(dll_path).zero?
       abort "Failed to load libmysql.dll from #{dll_path}"
     end
   end