Skip to content

Commit 70ab0dc

Browse files
committed
GitHub Actions: Set the default value to allow-failure.
1 parent 9c8cf07 commit 70ab0dc

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

.github/workflows/build.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
# Run all the tests on the new environment as much as possible.
88
# https://docs.github.com/en/free-pro-team@latest/actions/reference/specifications-for-github-hosted-runners
99
runs-on: ${{ matrix.os }}
10-
continue-on-error: ${{ matrix.allow-failure }}
10+
continue-on-error: ${{ matrix.allow-failure || false }}
1111
strategy:
1212
matrix:
1313
os:
@@ -26,15 +26,14 @@ jobs:
2626
- 2.2
2727
- 2.1
2828
db: ['']
29-
allow-failure: [false]
3029
include:
3130
# Allow failure due to Mysql2::Error: Unknown system variable 'session_track_system_variables'.
3231
- {os: ubuntu-16.04, ruby: 2.4, db: mariadb10.0, allow-failure: true}
3332
# Comment out due to ci/setup.sh stucking.
34-
# - {os: ubuntu-18.04, ruby: 2.4, db: mariadb10.1, allow-failure: false}
33+
# - {os: ubuntu-18.04, ruby: 2.4, db: mariadb10.1}
3534
# `service mysql restart` fails.
3635
- {os: ubuntu-20.04, ruby: 2.4, db: mariadb10.3, allow-failure: true}
37-
- {os: ubuntu-18.04, ruby: 2.4, db: mysql57, allow-failure: false}
36+
- {os: ubuntu-18.04, ruby: 2.4, db: mysql57}
3837
# Allow failure due to the issue #1165.
3938
- {os: ubuntu-20.04, ruby: 2.4, db: mysql80, allow-failure: true}
4039
- {os: ubuntu-18.04, ruby: 'head', db: '', allow-failure: true}

.github/workflows/container.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ jobs:
77
name: >-
88
${{ matrix.distro }} ${{ matrix.image }}
99
runs-on: ubuntu-20.04 # focal
10-
continue-on-error: ${{ matrix.allow-failure }}
10+
continue-on-error: ${{ matrix.allow-failure || false }}
1111
strategy:
1212
matrix:
1313
include:
14-
- {distro: centos, image: 'centos:7', allow-failure: false}
14+
- {distro: centos, image: 'centos:7'}
1515
# Fedora latest stable version
1616
# Allow failure due to the following test failures.
1717
# https://github.com/brianmario/mysql2/issues/965

0 commit comments

Comments
 (0)