Merge pull request #427 from sodabrew/banzaiman_stringify

Connect to DB whose name consists entirely of numerics by coercing connection data types on the Ruby side.

Author: sodabrew

lib/mysql2/client.rb

@@ -56,6 +56,14 @@ def initialize(opts = {})
       socket   = opts[:socket] || opts[:sock]
       flags    = opts[:flags] ? opts[:flags] | @query_options[:connect_flags] : @query_options[:connect_flags]
 
+      # Correct the data types before passing these values down to the C level
+      user = user.to_s unless user.nil?
+      pass = pass.to_s unless pass.nil?
+      host = host.to_s unless host.nil?
+      port = port.to_i unless port.nil?
+      database = database.to_s unless database.nil?
+      socket = socket.to_s unless socket.nil?
+
       connect user, pass, host, port, database, socket, flags
     end
 

spec/configuration.yml.example

@@ -9,3 +9,9 @@ user:
   username: LOCALUSERNAME
   password:
   database: mysql2_test
+
+numericuser:
+  host: localhost
+  username: LOCALUSERNAME
+  password:
+  database: 12345

spec/mysql2/client_spec.rb

@@ -104,6 +104,16 @@ def connect *args
     ssl_client.close
   end
 
+  it "should be able to connect to database with numeric-only name" do
+    lambda {
+      creds = DatabaseCredentials['numericuser']
+      @client.query "CREATE DATABASE IF NOT EXISTS `#{creds['database']}`"
+      @client.query "GRANT ALL ON `#{creds['database']}`.* TO #{creds['username']}@`#{creds['host']}`"
+      client = Mysql2::Client.new creds
+      @client.query "DROP DATABASE IF EXISTS `#{creds['database']}`"
+    }.should_not raise_error
+  end
+
   it "should respond to #close" do
     @client.should respond_to(:close)
   end