Skip to content

Commit 79c6263

Browse files
authored
CI: Drop allow-failure option in some Ubuntu cases. (#1292)
As we fixed some of the issues, we can drop the allow-failure option in some cases. #1165 was resolved by mysql2 0.5.4, while #1194 needs attention.
1 parent 6525c02 commit 79c6263

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

.github/workflows/build.yml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,20 +30,18 @@ jobs:
3030
include:
3131
# Comment out due to ci/setup.sh stucking.
3232
# - {os: ubuntu-18.04, ruby: 2.4, db: mariadb10.1}
33-
# Allow failure due to the issue #965, #1165.
34-
- {os: ubuntu-20.04, ruby: '2.4', db: mariadb10.3, allow-failure: true}
33+
- {os: ubuntu-20.04, ruby: '2.4', db: mariadb10.3}
3534
- {os: ubuntu-18.04, ruby: '2.4', db: mysql57}
36-
# Allow failure due to the issue #1165.
37-
- {os: ubuntu-20.04, ruby: '2.4', db: mysql80, allow-failure: true}
38-
- {os: ubuntu-18.04, ruby: 'head', db: '', allow-failure: true}
35+
- {os: ubuntu-20.04, ruby: '2.4', db: mysql80}
36+
- {os: ubuntu-18.04, ruby: 'head', db: ''}
3937
# db: A DB's brew package name in macOS case.
4038
# Set a name "db: '[email protected]'" when using an old version.
4139
# MariaDB lastet version
4240
# Allow failure due to the following test failures that rarely happens.
4341
# https://github.com/brianmario/mysql2/issues/1194
4442
- {os: macos-latest, ruby: '2.6', db: mariadb, allow-failure: true}
4543
# MySQL latest version
46-
# Allow failure due to the issue #1165.
44+
# Allow failure due to the issue #1194.
4745
- {os: macos-latest, ruby: '2.6', db: mysql, allow-failure: true}
4846
# On the fail-fast: true, it cancels all in-progress jobs
4947
# if any matrix job fails unlike Travis fast_finish.

0 commit comments

Comments
 (0)