Use rb_absint_singlebit_p to reduce object allocation

Author: nurse

ext/mysql2/extconf.rb

@@ -14,6 +14,7 @@ def asplode(lib)
 
 # 2.1+
 have_func('rb_absint_size')
+have_func('rb_absint_singlebit_p')
 
 # 2.0-only
 have_header('ruby/thread.h') && have_func('rb_thread_call_without_gvl', 'ruby/thread.h')
@@ -23,7 +24,7 @@ def asplode(lib)
 have_func('rb_wait_for_single_fd')
 have_func('rb_hash_dup')
 have_func('rb_intern3')
-have_func('rb_big_cmp')
+have_func('rb_big_and')
 
 # borrowed from mysqlplus
 # http://github.com/oldmoe/mysqlplus/blob/master/ext/extconf.rb

ext/mysql2/statement.c

@@ -224,8 +224,10 @@ static int my_big2ll(VALUE bignum, LONG_LONG *ptr)
     }
     else {
         if (len == 8 && nlz_bits == 0 &&
-#ifdef HAVE_RB_BIG_AND
-                rb_big_and(bignum, LL2NUM(LLONG_MAX>>1)) != INT2FIX(0)
+#ifdef HAVE_RB_ABSINT_SINGLEBIT_P
+                !rb_absint_singlebit_p(bignum)
+#elif defined(HAVE_RB_BIG_AND)
+                rb_big_and(bignum, LL2NUM(LLONG_MAX)) != INT2FIX(0)
 #else
                 rb_big_cmp(bignum, LL2NUM(LLONG_MIN)) == INT2FIX(-1)
 #endif

spec/mysql2/statement_spec.rb

@@ -68,20 +68,16 @@
   end
 
   it "should handle bignum but beyond int64_t" do
-    stmt = @client.prepare('SELECT ? AS max1, ? AS min1')
+    stmt = @client.prepare('SELECT ? AS max1, ? AS max2, ? AS min1, ? AS min2, ? AS min3')
     int64_max1 = (1 << 63)
+    int64_max2 = (1 << 64) - 1
     int64_min1 = -(1 << 63) - 1
-    result = stmt.execute(int64_max1, int64_min1)
-    expect(result.to_a).to eq(['max1' => int64_max1.to_s, 'min1' => int64_min1.to_s])
+    int64_min2 = -(1 << 64) + 1
+    int64_min3 = -0xC000000000000000
+    result = stmt.execute(int64_max1, int64_max2, int64_min1, int64_min2, int64_min3)
+    expect(result.to_a).to eq(['max1' => int64_max1.to_s, 'max2' => int64_max2.to_s, 'min1' => int64_min1.to_s, 'min2' => int64_min2.to_s, 'min3' => int64_min3.to_s])
   end
 
-  it "should handle bignum but beyond uint64_t" do
-    stmt = @client.prepare('SELECT ? AS max1, ? AS min1')
-    int65_max1 = (1 << 64) - 1
-    int65_min1 = -(1 << 64) + 1
-    result = stmt.execute(int65_max1, int65_min1)
-    expect(result.to_a).to eq(['max1' => int65_max1.to_s, 'min1' => int65_min1.to_s])
-  end
   it "should keep its result after other query" do
     @client.query 'USE test'
     @client.query 'CREATE TABLE IF NOT EXISTS mysql2_stmt_q(a int)'