Lint/Eval

Author: tamird

.rubocop_todo.yml

@@ -1,5 +1,5 @@
 # This configuration was generated by `rubocop --auto-gen-config`
-# on 2015-03-12 17:46:21 -0700 using RuboCop version 0.29.1.
+# on 2015-03-12 17:46:52 -0700 using RuboCop version 0.29.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -10,10 +10,6 @@
 Lint/AssignmentInCondition:
   Enabled: false
 
-# Offense count: 1
-Lint/Eval:
-  Enabled: false
-
 # Offense count: 1
 Lint/RescueException:
   Enabled: false
@@ -51,7 +47,7 @@ Metrics/BlockNesting:
 Metrics/CyclomaticComplexity:
   Max: 23
 
-# Offense count: 238
+# Offense count: 237
 # Configuration parameters: AllowURI, URISchemes.
 Metrics/LineLength:
   Max: 232

mysql2.gemspec

@@ -1,6 +1,6 @@
 require File.expand_path('../lib/mysql2/version', __FILE__)
 
-Gem::Specification.new do |s|
+Mysql2::GEMSPEC = Gem::Specification.new do |s|
   s.name = 'mysql2'
   s.version = Mysql2::VERSION
   s.authors = ['Brian Lopez', 'Aaron Stone']

tasks/compile.rake

@@ -1,10 +1,8 @@
 require "rake/extensiontask"
 
-def gemspec
-  @clean_gemspec ||= eval(File.read(File.expand_path('../../mysql2.gemspec', __FILE__)))
-end
+load File.expand_path('../../mysql2.gemspec', __FILE__)
 
-Rake::ExtensionTask.new("mysql2", gemspec) do |ext|
+Rake::ExtensionTask.new("mysql2", Mysql2::GEMSPEC) do |ext|
   # put binaries into lib/mysql2/ or lib/mysql2/x.y/
   ext.lib_dir = File.join 'lib', 'mysql2'
 
@@ -60,7 +58,7 @@ file 'vendor/README' do |t|
 end
 
 file 'lib/mysql2/mysql2.rb' do |t|
-  name = gemspec.name
+  name = Mysql2::GEMSPEC.name
   File.open(t.name, 'wb') do |f|
     f.write <<-eoruby
 RUBY_VERSION =~ /(\\d+.\\d+)/