Performance/TimesMap

Author: tamird

.rubocop_todo.yml

@@ -51,15 +51,6 @@ Naming/HeredocDelimiterNaming:
   Exclude:
     - 'tasks/compile.rake'
 
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect.
-Performance/TimesMap:
-  Exclude:
-    - 'benchmark/active_record_threaded.rb'
-    - 'examples/threaded.rb'
-    - 'spec/mysql2/client_spec.rb'
-
 # Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.

benchmark/active_record_threaded.rb

@@ -14,7 +14,7 @@
     ActiveRecord::Base.establish_connection(opts.merge(:adapter => adapter))
 
     x.report(adapter) do
-      number_of_threads.times.map do
+      Array.new(number_of_threads) do
         Thread.new { ActiveRecord::Base.connection.execute('SELECT SLEEP(1)') }
       end.each(&:join)
     end

examples/threaded.rb

@@ -6,7 +6,7 @@
 
 # Should never exceed worst case 3.5 secs across all 20 threads
 Timeout.timeout(3.5) do
-  20.times.map do
+  Array.new(20) do
     Thread.new do
       overhead = rand(3)
       puts ">> thread #{Thread.current.object_id} query, #{overhead} sec overhead"

spec/mysql2/client_spec.rb

@@ -658,7 +658,7 @@ def run_gc
         sleep_time = 0.5
 
         # Note that each thread opens its own database connection
-        threads = 5.times.map do
+        threads = Array.new(5) do
           Thread.new do
             new_client do |client|
               client.query("SELECT SLEEP(#{sleep_time})")