Skip to content

Commit cf687ba

Browse files
sodabrewjustincase
authored andcommitted
Use global rb_intern strings instead of point of use
1 parent ec45f82 commit cf687ba

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

ext/mysql2/client.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,11 @@ VALUE cMysql2Client;
1818
extern VALUE mMysql2, cMysql2Error;
1919
static VALUE sym_id, sym_version, sym_async, sym_symbolize_keys, sym_as, sym_array, sym_stream;
2020
static ID intern_merge, intern_merge_bang, intern_error_number_eql, intern_sql_state_eql;
21+
static ID intern_brackets, intern_new;
2122

2223
#ifndef HAVE_RB_HASH_DUP
2324
VALUE rb_hash_dup(VALUE other) {
24-
return rb_funcall(rb_cHash, rb_intern("[]"), 1, other);
25+
return rb_funcall(rb_cHash, intern_brackets, 1, other);
2526
}
2627
#endif
2728

@@ -123,7 +124,7 @@ static VALUE rb_raise_mysql2_error(mysql_client_wrapper *wrapper) {
123124
rb_enc_associate(rb_sql_state, rb_usascii_encoding());
124125
#endif
125126

126-
e = rb_funcall(cMysql2Error, rb_intern("new"), 2, rb_error_msg, LONG2FIX(wrapper->server_version));
127+
e = rb_funcall(cMysql2Error, intern_new, 2, rb_error_msg, LONG2FIX(wrapper->server_version));
127128
rb_funcall(e, intern_error_number_eql, 1, UINT2NUM(mysql_errno(wrapper->client)));
128129
rb_funcall(e, intern_sql_state_eql, 1, rb_sql_state);
129130
rb_exc_raise(e);
@@ -1305,6 +1306,8 @@ void init_mysql2_client() {
13051306
sym_array = ID2SYM(rb_intern("array"));
13061307
sym_stream = ID2SYM(rb_intern("stream"));
13071308

1309+
intern_brackets = rb_intern("[]");
1310+
intern_new = rb_intern("new");
13081311
intern_merge = rb_intern("merge");
13091312
intern_merge_bang = rb_intern("merge!");
13101313
intern_error_number_eql = rb_intern("error_number=");

0 commit comments

Comments
 (0)