Add precision to time, datetime, and timestamp field types #1394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankane
force-pushed
the
field-types-precision
branch
from
1620280 to
2e843cb
Compare
4 tasks
|
I like this, but would need to put it into a major-ish release |
|
Makes sense. I think it should probably always include the precision in that case. |
ankane
force-pushed
the
field-types-precision
branch
from
2e843cb to
52b7b58
Compare
Off the cuff, yes, ish? I think so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
Result#field_typesto return the precision fortime,datetime, andtimestampfields (like other types).https://dev.mysql.com/doc/refman/8.4/en/fractional-seconds.html
Edit: Updated to only add the precision if not the default (for slightly more backwards compatibility)