Skip to content

Commit 65fd251

Browse files
committed
Make TimeZoneRegion::utc() return a TimeZoneRegion not an TimeZoneOffset
1 parent 727a192 commit 65fd251

File tree

9 files changed

+21
-15
lines changed

9 files changed

+21
-15
lines changed

src/Instant.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ public function jsonSerialize(): string
363363
*/
364364
public function toISOString(): string
365365
{
366-
return (string) ZonedDateTime::ofInstant($this, TimeZone::utc());
366+
return (string) ZonedDateTime::ofInstant($this, TimeZoneOffset::utc());
367367
}
368368

369369
/**

src/LocalDateTime.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -715,7 +715,7 @@ public function isPast(TimeZone $timeZone, ?Clock $clock = null): bool
715715
*/
716716
public function toNativeDateTime(): DateTime
717717
{
718-
return $this->atTimeZone(TimeZone::utc())->toNativeDateTime();
718+
return $this->atTimeZone(TimeZoneOffset::utc())->toNativeDateTime();
719719
}
720720

721721
/**

src/TimeZone.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,6 @@ public static function parse(string $text): TimeZone
4141
return TimeZoneRegion::parse($text);
4242
}
4343

44-
public static function utc(): TimeZoneOffset
45-
{
46-
return TimeZoneOffset::utc();
47-
}
4844

4945
/**
5046
* Returns the unique time-zone ID.

src/TimeZoneRegion.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,11 @@ public static function from(DateTimeParseResult $result): TimeZoneRegion
5555
return TimeZoneRegion::of($region);
5656
}
5757

58+
public static function utc() : TimeZoneRegion
59+
{
60+
return TimeZoneRegion::of('UTC');
61+
}
62+
5863
/**
5964
* Returns all the available time-zone identifiers.
6065
*

tests/InstantTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
use Brick\DateTime\DateTimeException;
99
use Brick\DateTime\Duration;
1010
use Brick\DateTime\Instant;
11-
use Brick\DateTime\TimeZone;
11+
use Brick\DateTime\TimeZoneOffset;
1212
use PHPUnit\Framework\Attributes\DataProvider;
1313

1414
use function json_encode;
@@ -658,7 +658,7 @@ public static function providerToString(): array
658658

659659
public function testAtTimeZone(): void
660660
{
661-
$timeZone = TimeZone::utc();
661+
$timeZone = TimeZoneOffset::utc();
662662
$instant = Instant::of(1000000000);
663663
$result = $instant->atTimeZone($timeZone);
664664
self::assertSame(1000000000, $result->getInstant()->getEpochSecond());

tests/TimeZoneOffsetTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
use Brick\DateTime\TimeZoneOffset;
1111
use DateTimeImmutable;
1212
use PHPUnit\Framework\Attributes\DataProvider;
13+
use Brick\DateTime\TimeZoneRegion;
1314

1415
use const PHP_VERSION_ID;
1516

tests/TimeZoneRegionTest.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,4 +163,11 @@ public function testToString(): void
163163
{
164164
self::assertSame('America/Los_Angeles', (string) TimeZoneRegion::of('America/Los_Angeles'));
165165
}
166+
167+
public function testUTC(): void
168+
{
169+
$utcTimeZoneRegion = TimeZoneRegion::utc();
170+
$this->assertInstanceOf(TimeZoneRegion::class, $utcTimeZoneRegion);
171+
$this->assertSame('UTC', $utcTimeZoneRegion->getId());
172+
}
166173
}

tests/TimeZoneTest.php

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -66,16 +66,13 @@ public static function providerParseInvalidStringThrowsException(): array
6666

6767
public function testUtc(): void
6868
{
69-
$utc = TimeZone::utc();
70-
71-
self::assertTimeZoneOffsetIs(0, $utc);
72-
self::assertSame($utc, TimeZone::utc());
69+
$this->assertTimeZoneOffsetIs(0, TimeZoneOffset::utc());
7370
}
7471

7572
public function testIsEqualTo(): void
7673
{
77-
self::assertTrue(TimeZone::utc()->isEqualTo(TimeZoneOffset::ofTotalSeconds(0)));
78-
self::assertFalse(TimeZone::utc()->isEqualTo(TimeZoneOffset::ofTotalSeconds(3600)));
74+
self::assertTrue(TimeZoneOffset::utc()->isEqualTo(TimeZoneOffset::ofTotalSeconds(0)));
75+
self::assertFalse(TimeZoneOffset::utc()->isEqualTo(TimeZoneOffset::ofTotalSeconds(3600)));
7976
}
8077

8178
/**

tests/ZonedDateTimeTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -520,7 +520,7 @@ public function testGetMonth(int $monthValue, Month $month): void
520520
{
521521
$zonedDateTime = ZonedDateTime::of(
522522
LocalDateTime::of(2000, $monthValue, 1),
523-
TimeZone::utc(),
523+
TimeZoneOffset::utc(),
524524
);
525525

526526
self::assertSame($month, $zonedDateTime->getMonth());

0 commit comments

Comments
 (0)