Psalm level 2

Author: BenMorel

composer.json

@@ -14,7 +14,8 @@
     },
     "require-dev": {
         "phpunit/phpunit": "^9.0",
-        "php-coveralls/php-coveralls": "^2.0"
+        "php-coveralls/php-coveralls": "^2.0",
+        "vimeo/psalm": "^4.1"
     },
     "autoload": {
         "psr-4": {

psalm.xml

@@ -0,0 +1,15 @@
+<?xml version="1.0"?>
+<psalm
+    errorLevel="2"
+    resolveFromConfigFile="true"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xmlns="https://getpsalm.org/schema/config"
+    xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
+>
+    <projectFiles>
+        <directory name="src" />
+        <ignoreFiles>
+            <directory name="vendor" />
+        </ignoreFiles>
+    </projectFiles>
+</psalm>

src/Request.php

@@ -1200,7 +1200,7 @@ private function parseQualityValues(string $header) : array
             $position--;
         }
 
-        usort($result, static function(array $a, array $b) {
+        usort($result, static function(array $a, array $b): int {
             return $b[2] - $a[2];
         });
 

src/UploadedFileMap.php

@@ -39,12 +39,10 @@ private static function normalizeSuperglobal(array $files) : array
         foreach ($files as $file) {
             $keys = array_keys($file);
 
-            if (is_array($keys)) {
-                foreach ($keys as $key) {
-                    $result[$key] = [];
-                    foreach ($files as $index => $file) {
-                        $result[$key][$index] = $file[$key];
-                    }
+            foreach ($keys as $key) {
+                $result[$key] = [];
+                foreach ($files as $index => $file) {
+                    $result[$key][$index] = $file[$key];
                 }
             }