Use PascalCase for enum cases

Author: BenMorel

README.md

@@ -331,11 +331,11 @@ The `JsonMapper` constructor accepts the following options:
 
   This option accepts an `OnExtraProperties` enum value, and controls how `JsonMapper` reacts if a JSON object contains a property that does not have a matching parameter in the corresponding DTO's constructor signature:
 
-  - **`OnExtraProperties::THROW_EXCEPTION`**
+  - **`OnExtraProperties::ThrowException`**
 
     `JsonMapper` will throw a `JsonMapperException`. This is the default value.
 
-  - **`OnExtraProperties::IGNORE`**
+  - **`OnExtraProperties::Ignore`**
 
     `JsonMapper` will ignore any extra properties:
 
@@ -360,7 +360,7 @@ The `JsonMapper` constructor accepts the following options:
     }';
 
     $mapper = new JsonMapper(
-        onExtraProperties: OnExtraProperties::IGNORE,
+        onExtraProperties: OnExtraProperties::Ignore,
     );
 
     // extra properties "extraProperty" and "otherExtraProperty" are ignored,
@@ -372,11 +372,11 @@ The `JsonMapper` constructor accepts the following options:
 
   This option accepts an `OnMissingProperties` enum value, and controls how `JsonMapper` reacts if a JSON object is missing a property that is declared in the corresponding DTO's constructor signature:
 
-  - **`OnMissingProperties::THROW_EXCEPTION`**
+  - **`OnMissingProperties::ThrowException`**
 
     `JsonMapper` will throw a `JsonMapperException`. This is the default value.
 
-  - **`OnMissingProperties::SET_NULL`**
+  - **`OnMissingProperties::SetNull`**
 
     `JsonMapper` will set the parameter to `null` if the JSON property is missing and the parameter is nullable:
 
@@ -398,7 +398,7 @@ The `JsonMapper` constructor accepts the following options:
     }';
 
     $mapper = new JsonMapper(
-        onMissingProperties: OnMissingProperties::SET_NULL,
+        onMissingProperties: OnMissingProperties::SetNull,
     );
 
     $order = $mapper->map($json, Order::class);
@@ -407,10 +407,10 @@ The `JsonMapper` constructor accepts the following options:
 
     If the property is missing and the parameter is not nullable, an exception will be thrown regardless of this option.
 
-  - **`OnMissingProperties::SET_DEFAULT`**
+  - **`OnMissingProperties::SetDefault`**
 
     `JsonMapper` will set the parameter to its default value if the JSON property is missing and the parameter has a default value:
-    
+
     ```php
     use Brick\JsonMapper\JsonMapper;
     use Brick\JsonMapper\OnMissingProperties;
@@ -429,7 +429,7 @@ The `JsonMapper` constructor accepts the following options:
     }';
 
     $mapper = new JsonMapper(
-        onMissingProperties: OnMissingProperties::SET_DEFAULT,
+        onMissingProperties: OnMissingProperties::SetDefault,
     );
 
     $order = $mapper->map($json, Order::class);

src/JsonMapper.php

@@ -61,14 +61,14 @@ public function __construct(
          * Extra properties are properties of the JSON object that do not have a corresponding constructor parameter in
          * the PHP class.
          */
-        private OnExtraProperties $onExtraProperties = OnExtraProperties::THROW_EXCEPTION,
+        private OnExtraProperties $onExtraProperties = OnExtraProperties::ThrowException,
 
         /**
          * Controls how missing properties in the JSON object are handled.
          * Missing properties are constructor parameters in the PHP class that do not have a corresponding property in
          * the JSON object.
          */
-        private OnMissingProperties $onMissingProperties = OnMissingProperties::THROW_EXCEPTION,
+        private OnMissingProperties $onMissingProperties = OnMissingProperties::ThrowException,
 
         /**
          * Mapper to convert JSON property names to PHP property names.
@@ -151,7 +151,7 @@ private function mapToObject(stdClass $jsonData, string $className): object
             );
         }
 
-        if ($this->onExtraProperties === OnExtraProperties::THROW_EXCEPTION) {
+        if ($this->onExtraProperties === OnExtraProperties::ThrowException) {
             /** @psalm-suppress MixedAssignment, RawObjectIteration */
             foreach ($jsonData as $jsonPropertyName => $_) {
                 /** @var string $jsonPropertyName https://github.com/vimeo/psalm/issues/9108 */
@@ -184,13 +184,13 @@ private function getParameterValue(
         $parameterType = $this->reflector->getParameterType($reflectionParameter);
 
         if (! property_exists($jsonData, $jsonPropertyName)) {
-            if ($this->onMissingProperties === OnMissingProperties::SET_NULL) {
+            if ($this->onMissingProperties === OnMissingProperties::SetNull) {
                 if ($parameterType->allowsNull) {
                     return null;
                 }
             }
 
-            if ($this->onMissingProperties === OnMissingProperties::SET_DEFAULT) {
+            if ($this->onMissingProperties === OnMissingProperties::SetDefault) {
                 if ($reflectionParameter->isDefaultValueAvailable()) {
                     // TODO we should technically check if the default value is compatible with the parameter type,
                     //      as the type declared as @param may be more specific than the PHP type.
@@ -201,9 +201,9 @@ private function getParameterValue(
             throw new JsonMapperException([
                 sprintf('Missing property "%s" in JSON data.', $jsonPropertyName),
                 match ($this->onMissingProperties) {
-                    OnMissingProperties::SET_NULL => 'The parameter does not allow null.',
-                    OnMissingProperties::SET_DEFAULT => 'The parameter does not have a default value.',
-                    OnMissingProperties::THROW_EXCEPTION => 'If you want to allow missing properties, change the $onMissingProperties option.',
+                    OnMissingProperties::SetNull => 'The parameter does not allow null.',
+                    OnMissingProperties::SetDefault => 'The parameter does not have a default value.',
+                    OnMissingProperties::ThrowException => 'If you want to allow missing properties, change the $onMissingProperties option.',
                 },
             ]);
         }

src/OnExtraProperties.php

@@ -6,6 +6,16 @@
 
 enum OnExtraProperties
 {
-    case THROW_EXCEPTION;
-    case IGNORE;
+    case ThrowException;
+    case Ignore;
+
+    /**
+     * @deprecated Use OnExtraProperties::ThrowException
+     */
+    public const THROW_EXCEPTION = self::ThrowException;
+
+    /**
+     * @deprecated Use OnExtraProperties::Ignore
+     */
+    public const IGNORE = self::Ignore;
 }

src/OnMissingProperties.php

@@ -6,7 +6,22 @@
 
 enum OnMissingProperties
 {
-    case THROW_EXCEPTION;
-    case SET_NULL;
-    case SET_DEFAULT;
+    case ThrowException;
+    case SetNull;
+    case SetDefault;
+
+    /**
+     * @deprecated Use OnMissingProperties::ThrowException
+     */
+    public const THROW_EXCEPTION = self::ThrowException;
+
+    /**
+     * @deprecated Use OnMissingProperties::SetNull
+     */
+    public const SET_NULL = self::SetNull;
+
+    /**
+     * @deprecated Use OnMissingProperties::SetDefault
+     */
+    public const SET_DEFAULT = self::SetDefault;
 }

tests/JsonMapperTest.php

@@ -147,7 +147,7 @@ public function testMapWithOnExtraPropertiesIgnore(): void
             }
             JSON;
 
-        $jsonMapper = new JsonMapper(onExtraProperties: OnExtraProperties::IGNORE);
+        $jsonMapper = new JsonMapper(onExtraProperties: OnExtraProperties::Ignore);
         $artist = $jsonMapper->map($json, Artist::class);
 
         self::assertInstanceOf(Artist::class, $artist);
@@ -186,7 +186,7 @@ public function testMapWithOnMissingPropertiesSetNull(): void
             }
             JSON;
 
-        $jsonMapper = new JsonMapper(onMissingProperties: OnMissingProperties::SET_NULL);
+        $jsonMapper = new JsonMapper(onMissingProperties: OnMissingProperties::SetNull);
         $artist = $jsonMapper->map($json, Artist::class);
 
         self::assertInstanceOf(Artist::class, $artist);
@@ -205,7 +205,7 @@ public function testMapWithOnMissingPropertiesSetDefault(): void
             }
             JSON;
 
-        $jsonMapper = new JsonMapper(onMissingProperties: OnMissingProperties::SET_DEFAULT);
+        $jsonMapper = new JsonMapper(onMissingProperties: OnMissingProperties::SetDefault);
         $artist = $jsonMapper->map($json, Artist::class);
 
         self::assertInstanceOf(Artist::class, $artist);