Readonly classes/props

Author: BenMorel

src/JsonMapper.php

@@ -33,9 +33,9 @@
 /**
  * @psalm-suppress MixedAssignment
  */
-final class JsonMapper
+final readonly class JsonMapper
 {
-    private readonly Reflector $reflector;
+    private Reflector $reflector;
 
     public function __construct(
         /**
@@ -61,26 +61,26 @@ public function __construct(
          * Extra properties are properties of the JSON object that do not have a corresponding constructor parameter in
          * the PHP class.
          */
-        private readonly OnExtraProperties $onExtraProperties = OnExtraProperties::THROW_EXCEPTION,
+        private OnExtraProperties $onExtraProperties = OnExtraProperties::THROW_EXCEPTION,
 
         /**
          * Controls how missing properties in the JSON object are handled.
          * Missing properties are constructor parameters in the PHP class that do not have a corresponding property in
          * the JSON object.
          */
-        private readonly OnMissingProperties $onMissingProperties = OnMissingProperties::THROW_EXCEPTION,
+        private OnMissingProperties $onMissingProperties = OnMissingProperties::THROW_EXCEPTION,
 
         /**
          * Mapper to convert JSON property names to PHP property names.
          * By default, no conversion is performed.
          */
-        private readonly NameMapper $jsonToPhpNameMapper = new NullMapper(),
+        private NameMapper $jsonToPhpNameMapper = new NullMapper(),
 
         /**
          * Mapper to convert PHP property names to JSON property names.
          * By default, no conversion is performed.
          */
-        private readonly NameMapper $phpToJsonNameMapper = new NullMapper(),
+        private NameMapper $phpToJsonNameMapper = new NullMapper(),
     ) {
         $this->reflector = new Reflector(
             $allowUntypedArrays,

src/Reflection/Type/ArrayType.php

@@ -12,10 +12,10 @@
 /**
  * @internal This class is not part of the public API, and may change without notice.
  */
-final class ArrayType implements Stringable
+final readonly class ArrayType implements Stringable
 {
     public function __construct(
-        public readonly UnionType $type,
+        public UnionType $type,
     ) {
     }
 

src/Reflection/Type/ClassType.php

@@ -10,13 +10,13 @@
 /**
  * @internal This class is not part of the public API, and may change without notice.
  */
-final class ClassType implements Stringable
+final readonly class ClassType implements Stringable
 {
     /**
      * @param class-string $name
      */
     public function __construct(
-        public readonly string $name,
+        public string $name,
     ) {
     }
 

src/Reflection/Type/EnumType.php

@@ -12,15 +12,15 @@
 /**
  * @internal This class is not part of the public API, and may change without notice.
  */
-final class EnumType implements Stringable
+final readonly class EnumType implements Stringable
 {
     /**
      * @param class-string<BackedEnum> $name
      */
     public function __construct(
-        public readonly string $name,
-        public readonly bool $isIntBacked = false,
-        public readonly bool $isStringBacked = false,
+        public string $name,
+        public bool $isIntBacked = false,
+        public bool $isStringBacked = false,
     ) {
         if (! ($this->isIntBacked xor $this->isStringBacked)) {
             throw new InvalidArgumentException('EnumType must be either int or string backed.');

src/Reflection/Type/SimpleType.php

@@ -10,10 +10,10 @@
 /**
  * @internal This class is not part of the public API, and may change without notice.
  */
-final class SimpleType implements Stringable
+final readonly class SimpleType implements Stringable
 {
     public function __construct(
-        public readonly string $name,
+        public string $name,
     ) {
     }
 

src/Reflection/Type/UnionType.php

@@ -24,50 +24,50 @@
  *
  * @internal This class is not part of the public API, and may change without notice.
  */
-final class UnionType implements Stringable
+final readonly class UnionType implements Stringable
 {
-    public readonly bool $allowsInt;
+    public bool $allowsInt;
 
-    public readonly bool $allowsFloat;
+    public bool $allowsFloat;
 
-    public readonly bool $allowsString;
+    public bool $allowsString;
 
-    public readonly bool $allowsTrue;
+    public bool $allowsTrue;
 
-    public readonly bool $allowsFalse;
+    public bool $allowsFalse;
 
-    public readonly bool $allowsNull;
+    public bool $allowsNull;
 
-    public readonly bool $allowsRawArray;
+    public bool $allowsRawArray;
 
-    public readonly bool $allowsRawObject;
+    public bool $allowsRawObject;
 
-    public readonly bool $allowsMixed;
+    public bool $allowsMixed;
 
     /**
      * @var ClassType[]
      */
-    public readonly array $classTypes;
+    public array $classTypes;
 
     /**
      * At most one enum type per backed type (int, string) is allowed in a union.
      *
      * @var EnumType[]
      */
-    public readonly array $enumTypes;
+    public array $enumTypes;
 
     /**
      * At most one ArrayType is allowed in a union.
      */
-    public readonly ?ArrayType $arrayType;
+    public ?ArrayType $arrayType;
 
     /**
      * @param (SimpleType|ClassType|EnumType|ArrayType)[] $types
      *
      * @throws JsonMapperException
      */
     public function __construct(
-        public readonly array $types,
+        public array $types,
     ) {
         $this->ensureNotEmpty();
         $this->ensureNoDuplicateTypes();

src/Reflection/TypeParser.php

@@ -44,7 +44,7 @@ final class TypeParser
     private int $pointer = 0;
 
     public function __construct(
-        private string $type,
+        private readonly string $type,
     ) {
     }
 

src/Reflection/TypeToken.php

@@ -7,12 +7,12 @@
 /**
  * @internal This class is not part of the public API, and may change without notice.
  */
-final class TypeToken
+final readonly class TypeToken
 {
     public function __construct(
-        public readonly string $value,
-        public readonly int $offset,
-        public readonly bool $isNamedType,
+        public string $value,
+        public int $offset,
+        public bool $isNamedType,
     ) {
     }
 }

tests/Attributes/ExpectException.php

@@ -7,7 +7,7 @@
 use Attribute;
 
 #[Attribute(Attribute::TARGET_PARAMETER)]
-final class ExpectException
+final readonly class ExpectException
 {
     /**
      * @param array{
@@ -17,9 +17,9 @@ final class ExpectException
      * } $config
      */
     public function __construct(
-        public readonly string $message,
-        public readonly array $config = [],
-        public readonly ?int $maxPhpVersionId = null,
+        public string $message,
+        public array $config = [],
+        public ?int $maxPhpVersionId = null,
     ) {
     }
 }

tests/Attributes/ExpectParameterType.php

@@ -7,7 +7,7 @@
 use Attribute;
 
 #[Attribute(Attribute::TARGET_PARAMETER)]
-final class ExpectParameterType
+final readonly class ExpectParameterType
 {
     /**
      * @param array{
@@ -17,8 +17,8 @@ final class ExpectParameterType
      * } $config
      */
     public function __construct(
-        public readonly string $type,
-        public readonly array $config = [],
+        public string $type,
+        public array $config = [],
     ) {
     }
 }