Skip to content

Commit f27ccbf

Browse files
jonmeowdanakj
andauthored
Add CODEOWNERS for review assignment (carbon-language#6153)
This disables the autoassign action so that the codeowners approach can be tested without interference. Trying this out because it might be a path for vacation handling. See [GitHub docs](https://docs.github.com/en/organizations/organizing-members-into-teams/managing-code-review-settings-for-your-team) and [#infra](https://discord.com/channels/655572317891461132/707150492370862090/1422985757311635620) --------- Co-authored-by: Dana Jansens <[email protected]>
1 parent a24598f commit f27ccbf

File tree

4 files changed

+32
-70
lines changed

4 files changed

+32
-70
lines changed

.github/workflows/auto_assign_prs.yaml

Lines changed: 0 additions & 63 deletions
This file was deleted.

CODEOWNERS

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
# Part of the Carbon Language project, under the Apache License v2.0 with LLVM
2+
# Exceptions. See /LICENSE for license information.
3+
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
4+
5+
# This file is only used for PR autoassignment. Branch protections don't enforce
6+
# it.
7+
#
8+
# Syntax:
9+
# https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-syntax
10+
11+
# Toolchain reviewers are used as a fallback.
12+
* @carbon-language/toolchain-reviewers
13+
14+
# Key project documents should be reviewed by leads.
15+
/*.md @carbon-language/leads
16+
/LICENSE @carbon-language/leads
17+
/docs/project/evolution.md @carbon-language/leads
18+
/docs/project/goals.md @carbon-language/leads
19+
/docs/project/principles/* @carbon-language/leads
20+
/docs/project/roadmap.md @carbon-language/leads
21+
/proposals/*.md @carbon-language/leads
22+
23+
# Toolchain code.
24+
/toolchain @carbon-language/toolchain-reviewers

docs/project/code_review.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,11 @@ In Carbon, developers will focus on particular areas, loosely broken down as:
8686
- We split out auto-assignment by explorer, toolchain, and other files
8787
(including documentation).
8888

89-
[Auto-assignment](/.github/workflows/auto_assign_prs.yaml) will help find
90-
owners, but won't always be perfect -- developers may take a PR they weren't
91-
auto-assigned in order to help review go quickly. Contributors can also request
92-
multiple reviewers, but it can be daunting to get feedback from a large number
93-
of reviewers, so we suggest keeping the number of reviewers reasonably small.
89+
[Auto-assignment](/CODEOWNERS) will help find owners, but won't always be
90+
perfect -- developers may take a PR they weren't auto-assigned in order to help
91+
review go quickly. Contributors can also request multiple reviewers, but it can
92+
be daunting to get feedback from a large number of reviewers, so we suggest
93+
keeping the number of reviewers reasonably small.
9494

9595
Any reviews that explicitly request changes should be addressed, either with the
9696
changes or an explanation of why not, before a pull request is merged. Further,

proposals/p1367.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,9 @@ group access controls are the last word on who can commit PRs.
110110

111111
### Auto-assignment
112112

113-
This PR [introduces auto-assignment](/.github/workflows/auto_assign_prs.yaml) in
114-
order to ensure PRs aren't lost. It provides categories of assignment, and a
113+
This PR
114+
[introduces auto-assignment](https://github.com/carbon-language/carbon-lang/pull/1367/files#diff-5e5db53c34ec04ba9da95c70d5c797f1be9f390f7e2bf18ca3149cbd99c277df)
115+
in order to ensure PRs aren't lost. It provides categories of assignment, and a
115116
fallback for other PRs that don't have explicit assignment.
116117

117118
### Stacked PRs

0 commit comments

Comments
 (0)