fix most of right panel (#248)

Co-authored-by: sschweid <sschweid@paloaltonetworks.com>

Author: saarschweid

src/main/kotlin/com/bridgecrew/ui/rightPanel/dictionaryDetails/DictionaryExtraInfoPanel.kt

@@ -67,5 +67,15 @@ abstract class DictionaryExtraInfoPanel : JPanel() {
             valueLabel.toolTipText = valueAsString
             add(valueLabel, valueConstraints)
         }
+
+        // Add a stub panel to push the dictionary to the top
+        val constraints = GridBagConstraints().apply {
+            weighty = 1.0
+            anchor = GridBagConstraints.SOUTH
+            fill = GridBagConstraints.VERTICAL
+        }
+        val emptyPanel = JPanel()
+        emptyPanel.background = UIUtil.getEditorPaneBackground()
+        add(emptyPanel, constraints)
     }
 }

src/main/kotlin/com/bridgecrew/ui/rightPanel/extraInfoPanel/CheckovExtraInfoPanel.kt

@@ -3,7 +3,6 @@ package com.bridgecrew.ui.rightPanel.extraInfoPanel
 import com.bridgecrew.results.BaseCheckovResult
 import com.bridgecrew.ui.CodeDiffPanel
 import com.intellij.util.ui.UIUtil
-import java.awt.Dimension
 import javax.swing.*
 
 open class CheckovExtraInfoPanel(val result: BaseCheckovResult): JPanel() {
@@ -13,12 +12,6 @@ open class CheckovExtraInfoPanel(val result: BaseCheckovResult): JPanel() {
         background = UIUtil.getEditorPaneBackground()
     }
 
-    fun setDimensions(){
-        if(result.fixDefinition == null) {
-            add(Box.Filler(Dimension(0,0), Dimension(0, 0), Dimension(0, Short.MAX_VALUE.toInt())))
-        }
-    }
-
     fun addCodeDiffPanel(){
         if(result.fixDefinition != null){
             add(CodeDiffPanel(result, true))

src/main/kotlin/com/bridgecrew/ui/rightPanel/extraInfoPanel/IacExtraInfoPanel.kt

@@ -9,6 +9,5 @@ class IacExtraInfoPanel(result: BaseCheckovResult): CheckovExtraInfoPanel(result
         initLayout()
         add(IacDictionaryPanel(result))
         addCodeDiffPanel()
-        setDimensions()
     }
 }

src/main/kotlin/com/bridgecrew/ui/rightPanel/extraInfoPanel/LicenseExtraInfoPanel.kt

@@ -4,10 +4,10 @@ import com.bridgecrew.results.LicenseCheckovResult
 import com.bridgecrew.ui.rightPanel.dictionaryDetails.LicenseDictionaryPanel
 
 class LicenseExtraInfoPanel(result: LicenseCheckovResult) : CheckovExtraInfoPanel(result) {
+
     init {
         initLayout()
         add(LicenseDictionaryPanel(result))
         addCodeDiffPanel()
-        setDimensions()
     }
 }

src/main/kotlin/com/bridgecrew/ui/rightPanel/extraInfoPanel/SecretsExtraInfoPanel.kt

@@ -9,6 +9,5 @@ class SecretsExtraInfoPanel(result: SecretsCheckovResult) : CheckovExtraInfoPane
         initLayout()
         add(SecretsDictionaryPanel(result))
         addCodeDiffPanel()
-        setDimensions()
     }
 }

src/main/kotlin/com/bridgecrew/ui/rightPanel/extraInfoPanel/VulnerabilitiesExtraInfoPanel.kt

@@ -9,6 +9,5 @@ class VulnerabilitiesExtraInfoPanel(result: VulnerabilityCheckovResult): Checkov
         initLayout()
         add(VulnerabilitiesDictionaryPanel(result))
         addCodeDiffPanel()
-        setDimensions()
     }
 }