-
Notifications
You must be signed in to change notification settings - Fork 43
Open
Description
An attempt was made to workaround bug #206 downstream by using the suppression feature: bvaughn/react-virtualized#1635
However, that workaround didn't seem to work - the problem still exists with the version deployed afterwards.
I didn't try debugging it, but after a quick code-review I theorize this is caused by additional directives being added before babel-plugin-flow-react-proptypes runs. It might be a different reason, but this stands out.
The code only checks the first directive:
babel-plugin-flow-react-proptypes/src/index.js
Lines 516 to 522 in 67027b9
| const directives = path.node.directives; | |
| if(directives && directives.length) { | |
| const directive = directives[0]; | |
| if (directive.value && directive.value.value === SUPPRESS_STRING) { | |
| suppress = true; | |
| } | |
| } |
I'm not sure why this isn't something like:
const directives = path.node.directives ?? [];
directives.forEach((directive) => {
if (directive.value && directive.value.value === SUPPRESS_STRING) {
suppress = true;
}
}) Obviously a fix for #206 would be more important, but I think the suppression should also be improved.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels