Skip to content

Commit 1ae1451

Browse files
committed
defer export and fix duplication mention in CLAUDE
1 parent 7575a6f commit 1ae1451

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

.github/workflows/cloudkit-sync-dev.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,4 +66,4 @@ jobs:
6666
cloudkit-key-id: ${{ secrets.CLOUDKIT_KEY_ID }}
6767
cloudkit-private-key: ${{ secrets.CLOUDKIT_PRIVATE_KEY }}
6868
virtualbuddy-api-key: ${{ secrets.VIRTUALBUDDY_API_KEY }}
69-
enable-export: 'true'
69+
enable-export: 'false' # Disabled until pagination is implemented (see issue #17)

.github/workflows/cloudkit-sync-prod.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,4 +40,4 @@ jobs:
4040
cloudkit-key-id: ${{ secrets.CLOUDKIT_KEY_ID_PROD }}
4141
cloudkit-private-key: ${{ secrets.CLOUDKIT_PRIVATE_KEY_PROD }}
4242
virtualbuddy-api-key: ${{ secrets.VIRTUALBUDDY_API_KEY }}
43-
enable-export: 'true'
43+
enable-export: 'false' # Disabled until pagination is implemented (see issue #17)

CLAUDE.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -656,13 +656,15 @@ The `main` branch requires:
656656

657657
As noted in README.md, this is a **demonstration project** with known limitations:
658658

659-
- No duplicate detection (repeated syncs create duplicate records)
660-
- No incremental sync (always fetches all data)
659+
- No incremental sync (always fetches all data from external sources)
661660
- No conflict resolution for concurrent updates
662661
- Limited error recovery in batch operations
662+
- **Export pagination**: Export only retrieves first 200 records per type (see Issue #8)
663663

664664
These are intentional to keep the demo focused on MistKit patterns rather than production robustness.
665665

666+
**Note on Duplicates**: The sync properly uses `.forceReplace` operations with deterministic record names (based on build numbers), so repeated syncs **update** existing records rather than creating duplicates.
667+
666668
## Additional Documentation
667669

668670
For detailed guides on advanced topics, see:

0 commit comments

Comments
 (0)