refactor: simplify JSON output by removing computed properties and jsonOutput flag

Remove unnecessary complexity from JSON output implementation:
- Remove custom encode(to:) method from DetailedSyncResult
- Remove computed properties (totalCreated, totalUpdated, totalFailed, totalRecords)
- Remove jsonOutput boolean configuration (keep only jsonOutputFile)
- Always show human-readable summary to console
- Calculate totals manually in both SyncCommand and GitHub Actions workflow

This addresses PR review feedback to simplify the implementation by:
1. Relying on stored properties only for JSON serialization
2. Using a single jsonOutputFile config instead of dual jsonOutput + jsonOutputFile

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: leogdion

.github/actions/cloudkit-sync/action.yml

@@ -249,7 +249,6 @@ runs:
         CLOUDKIT_ENVIRONMENT: ${{ inputs.environment }}
         CLOUDKIT_CONTAINER_ID: ${{ inputs.container-id }}
         VIRTUALBUDDY_API_KEY: ${{ inputs.virtualbuddy-api-key }}
-        BUSHEL_SYNC_JSON_OUTPUT: true
         BUSHEL_SYNC_JSON_OUTPUT_FILE: sync-result.json
       run: |
         echo "Starting CloudKit sync with change tracking..."
@@ -275,9 +274,10 @@ runs:
         SWIFT_UPDATED=$(jq '.swiftVersions.updated' sync-result.json)
         SWIFT_FAILED=$(jq '.swiftVersions.failed' sync-result.json)
 
-        TOTAL_CREATED=$(jq '.totalCreated' sync-result.json)
-        TOTAL_UPDATED=$(jq '.totalUpdated' sync-result.json)
-        TOTAL_FAILED=$(jq '.totalFailed' sync-result.json)
+        # Calculate totals manually
+        TOTAL_CREATED=$((RESTORE_CREATED + XCODE_CREATED + SWIFT_CREATED))
+        TOTAL_UPDATED=$((RESTORE_UPDATED + XCODE_UPDATED + SWIFT_UPDATED))
+        TOTAL_FAILED=$((RESTORE_FAILED + XCODE_FAILED + SWIFT_FAILED))
 
         # Generate summary showing changes (not just totals)
         cat > sync-summary.md <<EOF

Sources/BushelCloudCLI/Commands/SyncCommand.swift

@@ -69,20 +69,15 @@ internal enum SyncCommand {
     do {
       let result = try await syncEngine.sync(options: options)
 
-      // Output based on format
-      if config.sync?.jsonOutput == true {
+      // Write JSON to file if path specified
+      if let outputFile = config.sync?.jsonOutputFile {
         let json = try result.toJSON(pretty: true)
-
-        // Write to file if path specified, otherwise print to stdout
-        if let outputFile = config.sync?.jsonOutputFile {
-          try json.write(toFile: outputFile, atomically: true, encoding: .utf8)
-          BushelCloudKit.ConsoleOutput.info("✅ JSON output written to: \(outputFile)")
-        } else {
-          print(json)
-        }
-      } else {
-        printSuccess(result)
+        try json.write(toFile: outputFile, atomically: true, encoding: .utf8)
+        BushelCloudKit.ConsoleOutput.info("✅ JSON output written to: \(outputFile)")
       }
+
+      // Always show human-readable summary
+      printSuccess(result)
     } catch {
       printError(error)
       Foundation.exit(1)
@@ -139,12 +134,16 @@ internal enum SyncCommand {
     printTypeResult("XcodeVersions", result.xcodeVersions)
     printTypeResult("SwiftVersions", result.swiftVersions)
 
+    let totalCreated = result.restoreImages.created + result.xcodeVersions.created + result.swiftVersions.created
+    let totalUpdated = result.restoreImages.updated + result.xcodeVersions.updated + result.swiftVersions.updated
+    let totalFailed = result.restoreImages.failed + result.xcodeVersions.failed + result.swiftVersions.failed
+
     print(String(repeating: "-", count: 60))
     print("TOTAL:")
-    print("  ✨ Created: \(result.totalCreated)")
-    print("  🔄 Updated: \(result.totalUpdated)")
-    if result.totalFailed > 0 {
-      print("  ❌ Failed:  \(result.totalFailed)")
+    print("  ✨ Created: \(totalCreated)")
+    print("  🔄 Updated: \(totalUpdated)")
+    if totalFailed > 0 {
+      print("  ❌ Failed:  \(totalFailed)")
     }
     print(String(repeating: "=", count: 60))
     print("\n💡 Next: Use 'bushel-cloud export' to view the synced data")

Sources/BushelCloudKit/CloudKit/SyncEngine.swift

@@ -79,22 +79,6 @@ public struct SyncEngine: Sendable {
     public let xcodeVersions: TypeSyncResult
     public let swiftVersions: TypeSyncResult
 
-    public var totalCreated: Int {
-      restoreImages.created + xcodeVersions.created + swiftVersions.created
-    }
-
-    public var totalUpdated: Int {
-      restoreImages.updated + xcodeVersions.updated + swiftVersions.updated
-    }
-
-    public var totalFailed: Int {
-      restoreImages.failed + xcodeVersions.failed + swiftVersions.failed
-    }
-
-    public var totalRecords: Int {
-      totalCreated + totalUpdated + totalFailed
-    }
-
     public init(
       restoreImages: TypeSyncResult, xcodeVersions: TypeSyncResult, swiftVersions: TypeSyncResult
     ) {
@@ -103,26 +87,6 @@ public struct SyncEngine: Sendable {
       self.swiftVersions = swiftVersions
     }
 
-    /// Custom encoding to include computed properties
-    public func encode(to encoder: Encoder) throws {
-      var container = encoder.container(keyedBy: CodingKeys.self)
-      try container.encode(restoreImages, forKey: .restoreImages)
-      try container.encode(xcodeVersions, forKey: .xcodeVersions)
-      try container.encode(swiftVersions, forKey: .swiftVersions)
-      try container.encode(totalCreated, forKey: .totalCreated)
-      try container.encode(totalUpdated, forKey: .totalUpdated)
-      try container.encode(totalFailed, forKey: .totalFailed)
-    }
-
-    private enum CodingKeys: String, CodingKey {
-      case restoreImages
-      case xcodeVersions
-      case swiftVersions
-      case totalCreated
-      case totalUpdated
-      case totalFailed
-    }
-
     /// Convert to JSON string
     public func toJSON(pretty: Bool = false) throws -> String {
       let encoder = JSONEncoder()

Sources/BushelCloudKit/Configuration/CommandConfigurations.swift

@@ -43,7 +43,6 @@ public struct SyncConfiguration: Sendable {
   public var force: Bool
   public var minInterval: Int?
   public var source: String?
-  public var jsonOutput: Bool
   public var jsonOutputFile: String?
 
   public init(
@@ -57,7 +56,6 @@ public struct SyncConfiguration: Sendable {
     force: Bool = false,
     minInterval: Int? = nil,
     source: String? = nil,
-    jsonOutput: Bool = false,
     jsonOutputFile: String? = nil
   ) {
     self.dryRun = dryRun
@@ -70,7 +68,6 @@ public struct SyncConfiguration: Sendable {
     self.force = force
     self.minInterval = minInterval
     self.source = source
-    self.jsonOutput = jsonOutput
     self.jsonOutputFile = jsonOutputFile
   }
 }

Sources/BushelCloudKit/Configuration/ConfigurationKeys.swift

@@ -107,7 +107,6 @@ internal enum ConfigurationKeys {
     internal static let force = ConfigKey<Bool>(bushelPrefixed: "sync.force")
     internal static let minInterval = OptionalConfigKey<Int>(bushelPrefixed: "sync.min_interval")
     internal static let source = OptionalConfigKey<String>(bushelPrefixed: "sync.source")
-    internal static let jsonOutput = ConfigKey<Bool>(bushelPrefixed: "sync.json_output")
     internal static let jsonOutputFile = OptionalConfigKey<String>(bushelPrefixed: "sync.json_output_file")
   }
 

Sources/BushelCloudKit/Configuration/ConfigurationLoader+Loading.swift

@@ -95,7 +95,6 @@ extension ConfigurationLoader {
       force: read(ConfigurationKeys.Sync.force),
       minInterval: read(ConfigurationKeys.Sync.minInterval),
       source: read(ConfigurationKeys.Sync.source),
-      jsonOutput: read(ConfigurationKeys.Sync.jsonOutput),
       jsonOutputFile: read(ConfigurationKeys.Sync.jsonOutputFile)
     )