Skip to content

Commit 4e7d8c1

Browse files
authored
remove output-check Makefile target and CI job (#6366)
They haven't caught a problem in a long time.
1 parent eafe66d commit 4e7d8c1

File tree

4 files changed

+1
-62
lines changed

4 files changed

+1
-62
lines changed

.github/workflows/ci.yaml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,3 @@ jobs:
3636
- run: mkdir dist -ea 0
3737
- run: go build -o dist ./cmd/...
3838
- run: go test -v ./mdtest
39-
output-check:
40-
runs-on: ubuntu-22.04
41-
steps:
42-
- uses: actions/checkout@v4
43-
- uses: actions/setup-go@v5
44-
with:
45-
go-version-file: go.mod
46-
- run: make install
47-
- run: make output-check

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
/bin/
22
/dist/
3-
/zed-sample-data/
43
node_modules/
54

65
.idea

Makefile

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,6 @@ tidy:
2929
go mod tidy
3030
git diff --exit-code -- go.mod go.sum
3131

32-
SAMPLEDATA:=zed-sample-data/README.md
33-
34-
$(SAMPLEDATA):
35-
git clone --depth=1 https://github.com/brimdata/zed-sample-data $(@D)
36-
37-
sampledata: $(SAMPLEDATA)
38-
3932
bin/minio: Makefile
4033
@curl -o $@ --compressed --create-dirs \
4134
https://dl.min.io/server/minio/release/$$(go env GOOS)-$$(go env GOARCH)/archive/minio.RELEASE.2022-05-04T07-45-27Z
@@ -59,9 +52,6 @@ test-run: build bin/minio
5952
test-heavy: build
6053
@PATH="$(CURDIR)/dist:$(PATH)" go test -tags=heavy ./mdtest
6154

62-
output-check: build $(SAMPLEDATA)
63-
scripts/output-check.sh
64-
6555
build: $(PEG_DEP)
6656
@mkdir -p dist
6757
@go build -ldflags='$(LDFLAGS)' -o dist ./cmd/...
@@ -92,5 +82,5 @@ test-ci: fmt tidy vet test-generate test-unit test-system test-heavy
9282
clean:
9383
@rm -rf dist
9484

95-
.PHONY: fmt tidy vet test-unit test-system test-heavy sampledata test-ci
85+
.PHONY: fmt tidy vet test-unit test-system test-heavy test-ci
9686
.PHONY: build install clean generate test-generate

scripts/output-check.sh

Lines changed: 0 additions & 41 deletions
This file was deleted.

0 commit comments

Comments
 (0)