-
Notifications
You must be signed in to change notification settings - Fork 136
Description
tl;dr
While the fix to #3210 allowed a test that had been failing in CI to start passing again, closer inspection shows that the user-facing "Pivot to logs" feature hasn't recovered to its prior working state. Specifically, if its use would result in the creation of a filter that would reference a nested record value, it currently behaves like a no-op.
Details
Repro is with commit 3d88139 and the attached foo.json test data:
{"_path":"conn","uid":5,"id":{"orig_h":"10.164.94.120"}}
{"_path":"dns","uid":7,"id":{"orig_h":"10.47.25.80"}}
{"_path":"conn","uid":7,"id":{"orig_h":"10.47.25.80"}}
The attached video shows we're able to use the right-click menu and Count By either the _path field or the id.orig_h field. However, when confronted with the table of counted results, attempting the right-click Pivot to Values on the count column only creates the expected filter query when the count had been by_path. For the id.orig_h case, nothing happens and no errors surface in DevTools.
Repro.mp4
By comparison, at commit 399d1f0 back before the #3210 symptoms occurred, the Pivot to Values created the correct filter in the id.orig_h case as well.