Skip to content

Commit a3081ef

Browse files
committed
Do not shadow Host header when proxying
Enable usage of Proxrox with hosts and configurations such as Heroku which dispatch based on the `Host` header.
1 parent 80fa723 commit a3081ef

File tree

6 files changed

+3
-10
lines changed

6 files changed

+3
-10
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# Changelog
22

3+
## 1.12.0
4+
- Enable usage of Proxrox with Heroku and many other hosters which dispatch based on the `Host` header.
5+
36
## 1.11.0
47
- All dependencies have been updated to their latest version.
58

lib/config_template.ejs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,14 +63,12 @@ http {
6363
location @proxy {
6464
proxy_pass <%- proxy['/'] %>;
6565
proxy_set_header X-Real-IP $remote_addr;
66-
proxy_set_header Host $host;
6766
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
6867
}
6968
<% } Object.keys(proxy).filter(function(url) { return url !== '/' || root === false; }).forEach(function(url) { %>
7069
location <%- url %> {
7170
proxy_pass <%- proxy[url] %>;
7271
proxy_set_header X-Real-IP $remote_addr;
73-
proxy_set_header Host $host;
7472
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
7573
}
7674
<% }); Object.keys(websocketProxy).forEach(function(url) { %>

test/expectedConfigs/proxies.conf

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,12 @@ http {
4040
location @proxy {
4141
proxy_pass http://127.0.0.1:8080;
4242
proxy_set_header X-Real-IP $remote_addr;
43-
proxy_set_header Host $host;
4443
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
4544
}
4645

4746
location /api {
4847
proxy_pass http://api.example.com;
4948
proxy_set_header X-Real-IP $remote_addr;
50-
proxy_set_header Host $host;
5149
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
5250
}
5351

test/expectedConfigs/proxies_without_static_asset_serving.conf

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,21 +34,18 @@ http {
3434
location / {
3535
proxy_pass http://127.0.0.1:3000;
3636
proxy_set_header X-Real-IP $remote_addr;
37-
proxy_set_header Host $host;
3837
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
3938
}
4039

4140
location /cms {
4241
proxy_pass http://127.0.0.1:8080;
4342
proxy_set_header X-Real-IP $remote_addr;
44-
proxy_set_header Host $host;
4543
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
4644
}
4745

4846
location /api {
4947
proxy_pass http://api.example.com;
5048
proxy_set_header X-Real-IP $remote_addr;
51-
proxy_set_header Host $host;
5249
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
5350
}
5451

test/expectedConfigs/proxies_without_try_files.conf

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,12 @@ http {
4040
location /cms {
4141
proxy_pass http://127.0.0.1:8080;
4242
proxy_set_header X-Real-IP $remote_addr;
43-
proxy_set_header Host $host;
4443
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
4544
}
4645

4746
location /api {
4847
proxy_pass http://api.example.com;
4948
proxy_set_header X-Real-IP $remote_addr;
50-
proxy_set_header Host $host;
5149
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
5250
}
5351

test/expectedConfigs/proxy.conf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ http {
4040
location @proxy {
4141
proxy_pass http://127.0.0.1:8080;
4242
proxy_set_header X-Real-IP $remote_addr;
43-
proxy_set_header Host $host;
4443
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
4544
}
4645

0 commit comments

Comments
 (0)