Skip to content

Commit 08bd9cf

Browse files
authored
fix condition to fix nextSibling as last chunk node (#19)
* fix condition * chore: upgrade bun in pipeline * chore: update pipeline * docs: add issue links to fix * chore: update dependencies
1 parent 6f484b0 commit 08bd9cf

File tree

5 files changed

+180
-8
lines changed

5 files changed

+180
-8
lines changed

.github/workflows/test.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ jobs:
1515
- name: Setup bun
1616
uses: oven-sh/setup-bun@v1
1717
with:
18-
bun-version: 1.1.4
18+
bun-version: 1.2.2
1919
- name: Install dependencies, build, and test
2020
run: bun install
21-
- run: bunx playwright install
22-
- run: bunx playwright install-deps
21+
- run: bunx playwright@1.43.1 install
22+
- run: bunx playwright@1.43.1 install-deps
2323
- run: bun run build
2424
- run: bun run bundlewatch
2525
- run: bun run test

bun.lock

Lines changed: 169 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bun.lockb

-28.7 KB
Binary file not shown.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,9 @@
5353
"example:spa-like": "bun run ./examples/spa-like/index.ts"
5454
},
5555
"devDependencies": {
56-
"typescript": "5.4.5",
57-
"@types/bun": "1.1.0",
58-
"bundlewatch": "0.3.3",
56+
"typescript": "5.7.3",
57+
"@types/bun": "1.2.2",
58+
"bundlewatch": "0.4.0",
5959
"playwright": "1.43.1"
6060
}
6161
}

src/index.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,9 +281,12 @@ async function htmlStreamWalker(
281281
parent = parent.parentElement;
282282
}
283283

284+
// Related issues to this ternary (hard to reproduce in a test):
285+
// https://github.com/brisa-build/diff-dom-streaming/pull/15
286+
// https://github.com/brisa-build/brisa/issues/739
284287
return waitChildren
285-
? streamInProgress
286-
: streamInProgress && !node.hasChildNodes?.();
288+
? streamInProgress && !node.hasChildNodes?.()
289+
: streamInProgress
287290
}
288291

289292
return {

0 commit comments

Comments
 (0)