Skip to content

Commit 013fced

Browse files
author
Chris Brody
authored
no-useless-escape rule fix in templates (#123)
(minor fixes in templates/android.js) removes an exception from `templates/.eslintrc.yml`
1 parent 300f70a commit 013fced

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

templates/.eslintrc.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
rules:
22
no-tabs: 0
3-
no-useless-escape: 0

templates/android.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ module.exports = platform => [{
1212
dependencies {
1313
// Matches recent template from React Native (0.60)
1414
// https://github.com/facebook/react-native/blob/0.60-stable/template/android/build.gradle#L16
15-
classpath("com.android.tools.build:gradle:$\{safeExtGet('gradlePluginVersion', '3.4.1')\}")
15+
classpath("com.android.tools.build:gradle:\${safeExtGet('gradlePluginVersion', '3.4.1')}")
1616
}
1717
}
1818
@@ -54,7 +54,7 @@ repositories {
5454
}
5555
5656
dependencies {
57-
implementation "com.facebook.react:react-native:$\{safeExtGet('reactnativeVersion', '+')\}"
57+
implementation "com.facebook.react:react-native:\${safeExtGet('reactnativeVersion', '+')}"
5858
}
5959
6060
def configureReactNativePom(def pom) {
@@ -107,7 +107,7 @@ afterEvaluate { project ->
107107
108108
android.libraryVariants.all { variant ->
109109
def name = variant.name.capitalize()
110-
task "jar$\{name\}"(type: Jar, dependsOn: variant.javaCompile) {
110+
task "jar\${name}"(type: Jar, dependsOn: variant.javaCompile) {
111111
from variant.javaCompile.destinationDir
112112
}
113113
}
@@ -121,7 +121,7 @@ afterEvaluate { project ->
121121
configuration = configurations.archives
122122
repositories.mavenDeployer {
123123
// Deploy to react-native-event-bridge/maven, ready to publish to npm
124-
repository url: "file://$\{projectDir\}/../android/maven"
124+
repository url: "file://\${projectDir}/../android/maven"
125125
126126
configureReactNativePom pom
127127
}

0 commit comments

Comments
 (0)