remove library API support for namespace (#276)

* remove library API support for namespace

followup to 0de40fa - remove Windows (C#) support (PR #264)

extra namespace parameter no longer needed was discovered through
mutation testing using Stryker Mutator (as reported in issue #274)

namespace parameter is commented out for now, at least

removed from library API since Windows platform is no longer supported

Note that it should be possible to add Windows platform support
and support the namespace parameter at some point in the future.

* update a related comment

* add another blank line to the affected code

* update an error logging test snapshot

Author: Chris Brody

lib/lib.js

@@ -67,7 +67,9 @@ const generateWithNormalizedOptions = ({
   className,
   modulePrefix,
   packageIdentifier = DEFAULT_PACKAGE_IDENTIFIER,
-  namespace,
+  // namespace - library API member removed since Windows platform
+  // is now removed (may be added back someday in the future)
+  // namespace,
   platforms = DEFAULT_PLATFORMS,
   tvosEnabled = false,
   githubAccount = DEFAULT_GITHUB_ACCOUNT,
@@ -164,7 +166,9 @@ const generateWithNormalizedOptions = ({
           name: className,
           moduleName,
           packageIdentifier,
-          namespace,
+          // namespace - library API member removed since Windows platform
+          // is now removed (may be added back someday in the future)
+          // namespace,
           platforms,
           tvosEnabled,
           githubAccount,

lib/normalized-options.js

@@ -18,9 +18,12 @@ module.exports = (options) => {
 
   const moduleName = options.moduleName;
 
-  // OPTIONS NOT DOCUMENTED, not supported by CLI:
+  // [TBD] option NOT DOCUMENTED & NOT SUPPORTED by CLI:
   const className = options.className;
-  const namespace = options.namespace;
+
+  // namespace - library API member removed since Windows platform
+  // is now removed (may be added back someday in the future)
+  // const namespace = options.namespace;
 
   return Object.assign(
     { name, prefix, modulePrefix },
@@ -31,8 +34,10 @@ module.exports = (options) => {
     className
       ? {}
       : { className: `${prefix}${pascalCase(name)}` },
-    namespace
-      ? {}
-      : { namespace: pascalCase(name).split(/(?=[A-Z])/).join('.') },
+    // namespace - library API member removed since Windows platform
+    // is now removed (may be added back someday in the future)
+    // namespace
+    //   ? {}
+    //   : { namespace: pascalCase(name).split(/(?=[A-Z])/).join('.') },
   );
 };

tests/with-mocks/cli/command/func/with-logging/with-error/__snapshots__/cli-command-with-logging-with-error.test.js.snap

@@ -45,9 +45,9 @@ Array [
     "error": Array [
       "Error: ENOPERM not permitted
     at Object.ensureDir (.../tests/with-mocks/cli/command/func/with-logging/with-error/cli-command-with-logging-with-error.test.js:9:27)
-    at ensureDir (.../lib/lib.js:155:15)
-    at generateLibraryModule (.../lib/lib.js:281:10)
-    at generateWithNormalizedOptions (.../lib/lib.js:298:10)
+    at ensureDir (.../lib/lib.js:157:15)
+    at generateLibraryModule (.../lib/lib.js:285:10)
+    at generateWithNormalizedOptions (.../lib/lib.js:302:10)
     at createLibraryModule (.../lib/cli-command.js:...
     at Object.func (.../tests/with-mocks/cli/command/func/with-logging/with-error/cli-command-with-logging-with-error.test.js:62:9)
     ",