add package engines & use please-upgrade-node (#295)

to enforce minimum Node.js version in CLI

Author: Chris Brody

lib/cli-program.js

@@ -1,8 +1,11 @@
+const pkg = require('./../package.json');
+require('please-upgrade-node')(pkg);
+
 const program = require('commander');
+
 const updateNotifier = require('update-notifier');
 
 const command = require('./cli-command');
-const pkg = require('./../package.json');
 
 updateNotifier({ pkg }).notify();
 

package.json

@@ -4,6 +4,9 @@
   "description": "Tool to create a React Native library module or view module with a single command",
   "bin": "bin/cli.js",
   "main": "lib/lib.js",
+  "engines": {
+    "node": ">= 8"
+  },
   "scripts": {
     "jest": "jest",
     "lint": "eslint .",
@@ -48,6 +51,7 @@
     "node-emoji": "^1.10.0",
     "param-case": "^2.1.1",
     "pascal-case": "^2.0.1",
+    "please-upgrade-node": "^3.2.0",
     "update-notifier": "^4.1.0"
   },
   "devDependencies": {

tests/with-mocks/cli/program/with-defaults/for-android/__snapshots__/cli-program-with-defaults-for-android.test.js.snap

@@ -2,6 +2,14 @@
 
 exports[`mocked cli-program.js runs correctly defaults 1`] = `
 Array [
+  Object {
+    "please-upgrade-node": Object {
+      "engines": Object {
+        "node": ">= 8",
+      },
+      "name": "create-react-native-module",
+    },
+  },
   Object {
     "notify": Object {},
   },

tests/with-mocks/cli/program/with-defaults/for-android/cli-program-with-defaults-for-android.test.js

@@ -1,6 +1,12 @@
 // special compact mocks for this test:
 const mysnap = [];
 const mockpushit = x => mysnap.push(x);
+jest.mock('please-upgrade-node', () => ({ name, engines }) => {
+  // only snapshot a limited number of fields
+  expect(name).toBeDefined();
+  expect(engines).toBeDefined();
+  mockpushit({ 'please-upgrade-node': { name, engines } });
+});
 jest.mock('update-notifier', () => ({ pkg }) => {
   // only check a limited number of fields in pkg
   expect(pkg.name).toBeDefined();

tests/with-mocks/cli/program/with-missing-args/__snapshots__/cli-program-with-missing-args.test.js.snap

@@ -2,6 +2,14 @@
 
 exports[`mocked cli-program.js shows help in case of missing args 1`] = `
 Array [
+  Object {
+    "please-upgrade-node": Object {
+      "engines": Object {
+        "node": ">= 8",
+      },
+      "name": "create-react-native-module",
+    },
+  },
   Object {
     "notify": Object {},
   },

tests/with-mocks/cli/program/with-missing-args/cli-program-with-missing-args.test.js

@@ -1,6 +1,12 @@
 // special compact mocks for this test:
 const mysnap = [];
 const mockpushit = x => mysnap.push(x);
+jest.mock('please-upgrade-node', () => ({ name, engines }) => {
+  // only snapshot a limited number of fields
+  expect(name).toBeDefined();
+  expect(engines).toBeDefined();
+  mockpushit({ 'please-upgrade-node': { name, engines } });
+});
 jest.mock('update-notifier', () => ({ pkg }) => {
   // only check a limited number of fields in pkg
   expect(pkg.name).toBeDefined();

yarn.lock

@@ -3864,6 +3864,13 @@ pkg-dir@^3.0.0:
   dependencies:
     find-up "^3.0.0"
 
+please-upgrade-node@^3.2.0:
+  version "3.2.0"
+  resolved "https://registry.yarnpkg.com/please-upgrade-node/-/please-upgrade-node-3.2.0.tgz#aeddd3f994c933e4ad98b99d9a556efa0e2fe942"
+  integrity sha512-gQR3WpIgNIKwBMVLkpMUeR3e1/E1y42bqDQZfql+kDeXd8COYfM8PQA4X6y7a8u9Ua9FHmsrrmirW2vHs45hWg==
+  dependencies:
+    semver-compare "^1.0.0"
+
 pn@^1.1.0:
   version "1.1.0"
   resolved "https://registry.yarnpkg.com/pn/-/pn-1.1.0.tgz#e2f4cef0e219f463c179ab37463e4e1ecdccbafb"
@@ -4262,6 +4269,11 @@ sax@^1.2.4:
   resolved "https://registry.yarnpkg.com/sax/-/sax-1.2.4.tgz#2816234e2378bddc4e5354fab5caa895df7100d9"
   integrity sha512-NqVDv9TpANUjFm0N8uM5GxL36UgKi9/atZw+x7YFnQ8ckwFGKrl4xX4yWtrey3UJm5nP1kUbnYgLopqWNSRhWw==
 
+semver-compare@^1.0.0:
+  version "1.0.0"
+  resolved "https://registry.yarnpkg.com/semver-compare/-/semver-compare-1.0.0.tgz#0dee216a1c941ab37e9efb1788f6afc5ff5537fc"
+  integrity sha1-De4hahyUGrN+nvsXiPavxf9VN/w=
+
 semver-diff@^3.1.1:
   version "3.1.1"
   resolved "https://registry.yarnpkg.com/semver-diff/-/semver-diff-3.1.1.tgz#05f77ce59f325e00e2706afd67bb506ddb1ca32b"