Skip to content

Commit 662bb75

Browse files
author
Christopher J. Brody
committed
add native item with package ID to package.json
in order to make the `android/build.gradle` artifact 100% generic i.e. rendered directly from the template, with zero module-specific customization
1 parent 7fefc28 commit 662bb75

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

templates/android.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module.exports = platform => [{
22
name: () => `${platform}/build.gradle`,
3-
content: ({ packageIdentifier }) => `// ${platform}/build.gradle
3+
content: () => `// ${platform}/build.gradle
44
55
// based on:
66
//
@@ -84,7 +84,7 @@ def configureReactNativePom(def pom) {
8484
name packageJson.title
8585
artifactId packageJson.name
8686
version = packageJson.version
87-
group = "${packageIdentifier}"
87+
group = packageJson.native.packageIdentifier
8888
description packageJson.description
8989
url packageJson.repository.baseUrl
9090

templates/general.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ ${name};
2121
`,
2222
}, {
2323
name: () => 'package.json',
24-
content: ({ moduleName, platforms, githubAccount, authorName, authorEmail, license }) => {
24+
content: ({ moduleName, packageIdentifier, platforms, githubAccount, authorName, authorEmail, license }) => {
2525
const peerDependencies =
2626
`{
2727
"react": "^16.8.1",
@@ -58,6 +58,9 @@ ${name};
5858
"license": "${license}",
5959
"licenseFilename": "LICENSE",
6060
"readmeFilename": "README.md",
61+
"native": {
62+
"packageIdentifier": "${packageIdentifier}"
63+
},
6164
"peerDependencies": ${peerDependencies},
6265
"devDependencies": ${devDependencies}
6366
}

0 commit comments

Comments
 (0)